fix(core): Fix Invoke-ExternalCommand regression
#5923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niheaven
approved these changes
Apr 25, 2024
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com> Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#5839 introduced a regression of invoking
msiexecnative command, causing the significantExit code was 1639error for installing MSI-based pacakges when the destination pathTARGETDIRcontaining whitespaces. This PR fixes the regression.Motivation and Context
Resolves: #5911 ScoopInstaller/Main#5721 ScoopInstaller/Main#5723 ScoopInstaller/Main#5725 ScoopInstaller/Main#5726 ScoopInstaller/Main#5728 ScoopInstaller/Main#5729 ScoopInstaller/Main#5730 ScoopInstaller/Main#5740 ScoopInstaller/Main#5741 ScoopInstaller/Extras#13154 ...
Contexts #5839 #5231 #5065 #83 ScoopInstaller/Install#76
How Has This Been Tested?
No unit test available, but you may create new VM sandbox with its username having whitespaces to test.
And I think this is a urgent patch that should be merged to a hotfix branch without involving the expiremental feature of sqlite cache.
Checklist:
developbranch.