Handle Votes outside of voting period #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
alexkeating
force-pushed
the
chore/add-tests-for-handling-votes-outside-testing-period
branch
3 times, most recently
from
7ae93fd to
f2ffc4e
Compare
alexkeating
force-pushed
the
bug/handle-unauthorized-sender
branch
from
c265997 to
df0ae18
Compare
alexkeating
force-pushed
the
chore/add-tests-for-handling-votes-outside-testing-period
branch
from
f2ffc4e to
3f0cb5d
Compare
alexkeating
force-pushed
the
bug/handle-unauthorized-sender
branch
from
df0ae18 to
675d890
Compare
alexkeating
force-pushed
the
chore/add-tests-for-handling-votes-outside-testing-period
branch
2 times, most recently
from
a7e5bfe to
3700d27
Compare
mds1
reviewed
Sep 14, 2023
This was referenced Sep 14, 2023
wildmolasses
changed the base branch from
bug/handle-unauthorized-sender
to
main
wildmolasses
force-pushed
the
chore/add-tests-for-handling-votes-outside-testing-period
branch
from
7a7fe72 to
85be767
Compare
wildmolasses
approved these changes
Sep 18, 2023
| l1Erc20.mint(address(this), uint96(_l2Against) + _l2InFavor + _l2Abstain); | ||
| l1Erc20.delegate(address(l1VotePool)); | ||
|
|
||
| uint256 _proposalId = l1VotePool.createProposalVote(address(l1Erc20)); |
There was a problem hiding this comment.
i love the test harness, although i sometimes get confused whether we're calling a contract method or harness method. I see _jumpToProposalEnd, a harness method, is prefixed with underscore. Should we prefix all harness methods with underscores?
There was a problem hiding this comment.
We have another issue to update the Harness to have an exposed prefix to make this clearer hopefully. #45
| @@ -163,6 +163,32 @@ contract CastVote is L2VoteAggregatorTest { | |||
| l2VoteAggregator.castVote(1, _support); | |||
| } | |||
|
|
|||
| function testFuzz_RevertWhen_AfterCastWindow( | |||
| uint96 _amount, | |||
There was a problem hiding this comment.
why are two params underscore prefix, but the others aren't?
There was a problem hiding this comment.
Good question, I will giv them all a prefix
test/WormholeL2VoteAggregator.t.sol
Outdated
| uint96 _amount, | ||
| uint8 _support, | ||
| uint256 proposalId, | ||
| uint64 timeToProposalEnd |
There was a problem hiding this comment.
Suggested change
| uint64 timeToProposalEnd | |
| uint64 proposalDuration |
alexkeating
force-pushed
the
chore/add-tests-for-handling-votes-outside-testing-period
branch
from
85be767 to
909b52b
Compare
|
Coverage after merging chore/add-tests-for-handling-votes-outside-testing-period into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This was referenced Sep 19, 2023
Closed
mds1
approved these changes
Sep 20, 2023
This was referenced Sep 25, 2023
Merged
This was referenced Oct 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #32