Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1 gas golfing #70

Merged
merged 1 commit into from
Oct 5, 2023
Merged

L1 gas golfing #70

merged 1 commit into from
Oct 5, 2023

Conversation

wildmolasses
Copy link
Contributor

@wildmolasses wildmolasses commented Sep 29, 2023

Resolves #30

@wildmolasses
Copy link
Contributor Author

wildmolasses commented Sep 29, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@wildmolasses wildmolasses force-pushed the 09-28-l1_gas_golfing branch 3 times, most recently from 9563910 to 29ee9c2 Compare October 3, 2023 21:04
@wildmolasses wildmolasses marked this pull request as ready for review October 3, 2023 21:05
Copy link
Collaborator

@alexkeating alexkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there may be another couple of optimization opportunities

src/WormholeL2ERC20.sol Show resolved Hide resolved
src/FakeERC20.sol Show resolved Hide resolved
src/WormholeReceiver.sol Show resolved Hide resolved
@wildmolasses wildmolasses force-pushed the 09-28-l1_gas_golfing branch 3 times, most recently from 2e7bf7c to 7c7a62b Compare October 4, 2023 20:12
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Coverage after merging 09-28-l1_gas_golfing into main will be

91.07%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   FakeERC20.sol100%100%100%100%
   L1Block.sol25%100%25%25%23, 27, 31
   L1VotePool.sol100%100%100%100%
   L2GovernorMetadata.sol100%100%100%100%
   L2VoteAggregator.sol89.16%86.36%100%86.67%109, 117, 123, 129, 135, 155, 217, 259, 262
   WormholeL1ERC20Bridge.sol88.46%66.67%100%93.33%100, 105, 78
   WormholeL1GovernorMetadataBridge.sol100%100%100%100%
   WormholeL1VotePool.sol100%100%100%100%
   WormholeL2ERC20.sol95.24%75%100%100%94
   WormholeL2GovernorMetadata.sol100%100%100%100%
   WormholeL2VoteAggregator.sol100%100%100%100%
   WormholeReceiver.sol100%100%100%100%
   WormholeSender.sol100%100%100%100%

@wildmolasses wildmolasses mentioned this pull request Oct 4, 2023
Copy link
Member

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice work @wildmolasses

@apbendi apbendi merged commit bee07e6 into main Oct 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

L1 Contract Gas Optimizations
3 participants