Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower gas limit and make it updateable #94

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Lower gas limit and make it updateable #94

merged 3 commits into from
Feb 15, 2024

Conversation

alexkeating
Copy link
Collaborator

@alexkeating alexkeating commented Dec 22, 2023 •
edited
Loading

Description

  • Lower gas limit
  • Make the gas limit updateable

@alexkeating
Copy link
Collaborator Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@alexkeating alexkeating marked this pull request as ready for review December 22, 2023 17:00
wildmolasses
wildmolasses requested changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@wildmolasses wildmolasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small things

src/WormholeSender.sol Outdated Show resolved Hide resolved
src/WormholeSender.sol Outdated Show resolved Hide resolved
test/WormholeBase.t.sol Outdated Show resolved Hide resolved
test/WormholeSender.t.sol Outdated Show resolved Hide resolved
@alexkeating alexkeating force-pushed the feature/add-gas-limit-setter branch from 459f50e to 8f51c20 Compare February 12, 2024 22:55
wildmolasses
wildmolasses approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@wildmolasses wildmolasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one nit, feel free to ignore

test/WormholeSender.t.sol Outdated Show resolved Hide resolved
@alexkeating alexkeating force-pushed the feature/add-gas-limit-setter branch from b93af56 to 3007bef Compare February 15, 2024 16:30
@alexkeating alexkeating force-pushed the feature/add-gas-limit-setter branch from 3007bef to d3ace8a Compare February 15, 2024 16:35
@github-actions GitHub Actions
Copy link

Coverage after merging feature/add-gas-limit-setter into main will be

94.80%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   L1VotePool.sol100%100%100%100%
   L2CountingFractional.sol81.03%55.56%100%90.63%118, 118, 163, 163, 170, 170, 200–202, 94, 94
   L2GovernorMetadata.sol93.33%75%100%100%103
   L2VoteAggregator.sol96.05%87.50%100%97.62%135, 216, 266
   WormholeL1ERC20Bridge.sol96.15%83.33%100%100%77
   WormholeL1GovernorMetadataBridge.sol100%100%100%100%
   WormholeL1VotePool.sol100%100%100%100%
   WormholeL2ERC20.sol100%100%100%100%
   WormholeL2GovernorMetadata.sol100%100%100%100%
   WormholeL2VoteAggregator.sol100%100%100%100%
   WormholeReceiver.sol100%100%100%100%
   WormholeSender.sol100%100%100%100%
src/optimized
   WormholeL2GovernorMetadataOptimized.sol100%100%100%100%
   WormholeL2VoteAggregatorCalldataCompressor.sol82.22%85.71%80%80.77%126–128, 128, 128–130

@alexkeating alexkeating merged commit 0c49282 into main Feb 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wildmolasses wildmolasses wildmolasses approved these changes

@apbendi apbendi Awaiting requested review from apbendi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexkeating @wildmolasses