We can now detect bouncy ballz

[egeakman]

No description provided.

[pep8speaks]

Hello @egeakman! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file misc/calibration/pixel_calculator.py:

Line 9:1: E402 module level import not at top of file
Line 24:1: E731 do not assign a lambda expression, use a def
Line 26:80: E501 line too long (86 > 79 characters)
Line 65:80: E501 line too long (85 > 79 characters)
Line 86:80: E501 line too long (83 > 79 characters)
Line 89:80: E501 line too long (86 > 79 characters)
Line 108:80: E501 line too long (82 > 79 characters)
Line 111:80: E501 line too long (85 > 79 characters)

• In the file misc/calibration/take_a_photo.py:

Line 11:1: E402 module level import not at top of file
Line 12:1: E402 module level import not at top of file
Line 13:1: E402 module level import not at top of file
Line 30:1: E731 do not assign a lambda expression, use a def
Line 33:80: E501 line too long (80 > 79 characters)
Line 36:80: E501 line too long (85 > 79 characters)
Line 39:80: E501 line too long (84 > 79 characters)
Line 117:80: E501 line too long (88 > 79 characters)
Line 126:80: E501 line too long (83 > 79 characters)
Line 131:80: E501 line too long (87 > 79 characters)
Line 135:80: E501 line too long (87 > 79 characters)
Line 141:80: E501 line too long (85 > 79 characters)
Line 145:80: E501 line too long (86 > 79 characters)

• In the file misc/functions/network.py:

Line 58:80: E501 line too long (86 > 79 characters)
Line 60:80: E501 line too long (87 > 79 characters)
Line 68:80: E501 line too long (86 > 79 characters)
Line 70:80: E501 line too long (87 > 79 characters)
Line 75:80: E501 line too long (86 > 79 characters)

• In the file misc/functions/shortener.py:

Line 6:1: E402 module level import not at top of file

• In the file misc/functions/video.py:

Line 8:1: E402 module level import not at top of file

• In the file misc/tests/test_classifier.py:

Line 6:1: E402 module level import not at top of file
Line 7:1: E402 module level import not at top of file
Line 8:1: E402 module level import not at top of file
Line 23:80: E501 line too long (84 > 79 characters)
Line 32:80: E501 line too long (80 > 79 characters)

• In the file misc/tests/test_modes.py:

Line 6:1: E402 module level import not at top of file

• In the file vision.py:

Line 62:80: E501 line too long (80 > 79 characters)
Line 74:80: E501 line too long (88 > 79 characters)
Line 79:80: E501 line too long (82 > 79 characters)

Comment last updated at 2022-01-30 17:03:49 UTC

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 6.76%.

Quality metrics	Before	After	Change
Complexity	10.63 🙂	6.52 ⭐	-4.11 👍
Method Length	61.88 🙂	60.86 ⭐	-1.02 👍
Working memory	13.27 😞	12.32 😞	-0.95 👍
Quality	54.97% 🙂	61.73% 🙂	6.76% 👍

Other metrics	Before	After	Change
Lines	552	823	271

Changed files	Quality Before	Quality After	Quality Change
vision.py	11.28% ⛔	23.01% ⛔	11.73% 👍
misc/calibration/find_hsv_range.py	44.94% 😞	46.12% 😞	1.18% 👍
misc/calibration/pixel_calculator.py	39.19% 😞	34.47% 😞	-4.72% 👎
misc/calibration/take_a_photo.py	44.88% 😞	49.10% 😞	4.22% 👍
misc/camera/fix_camera.py	60.23% 🙂	60.49% 🙂	0.26% 👍
misc/camera/set_camera.py	98.60% ⭐	98.80% ⭐	0.20% 👍
misc/flask/flask_server.py	88.69% ⭐	88.69% ⭐	0.00%
misc/functions/init.py	%	97.14% ⭐	%
misc/functions/camera.py	76.79% ⭐	76.48% ⭐	-0.31% 👎
misc/functions/flask_func.py	94.96% ⭐	95.16% ⭐	0.20% 👍
misc/functions/network.py	94.51% ⭐	88.89% ⭐	-5.62% 👎
misc/functions/process.py	78.42% ⭐	77.93% ⭐	-0.49% 👎
misc/functions/video.py	87.68% ⭐	86.27% ⭐	-1.41% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
misc/calibration/take_a_photo.py	on_press	9 🙂	134 😞	11 😞	54.01% 🙂	Try splitting into smaller methods. Extract out complex expressions
misc/functions/camera.py	switch	11 🙂	87 🙂	13 😞	55.01% 🙂	Extract out complex expressions
misc/functions/process.py	vision	2 ⭐	91 🙂	10 😞	68.26% 🙂	Extract out complex expressions
misc/functions/network.py	put	0 ⭐	75 🙂	10 😞	72.60% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!