Added more improvements about roles, roles mapping and it's testing #33

backend/src/slc_web/src/slc_web/__init__.py

@@ -6,6 +6,10 @@
 
 PACKAGE_NAME = "slc_web"
 
+# Permissions Roles
+ADD_SPONSOR_ROLES = ["Manager", "Site Administrator", "Sponsorship Committee"]
+MANAGE_SPONSOR_ROLES = ["Manager", "Sponsorship Committee"]
+
 _ = MessageFactory("slc_web")
 
 logger = logging.getLogger("slc_web")

backend/src/slc_web/src/slc_web/profiles/default/rolemap.xml

@@ -1,27 +1,27 @@
 <?xml version="1.0" encoding="utf-8"?>
 <rolemap>
   <roles>
-    <role name="Community Sponsorship Committee" />
+    <role name="Sponsorship Committee" />
     <role name="Community Membership Committee" />
   </roles>
   <permissions>
     <permission acquire="True"
                 name="Community Sponsor: Add Community Sponsor"
     >
-      <role name="Community Sponsorship Committee" />
+      <role name="Sponsorship Committee" />
       <role name="Manager" />
       <role name="Site Administrator" />
     </permission>
     <permission acquire="True"
                 name="Community Sponsor: View Detail"
     >
-      <role name="Community Sponsorship Committee" />
+      <role name="Sponsorship Committee" />
       <role name="Manager" />
     </permission>
     <permission acquire="True"
                 name="Community Sponsor: Manage Sponsors"
     >
-      <role name="Community Sponsorship Committee" />
+      <role name="Sponsorship Committee" />
       <role name="Manager" />
     </permission>
 

backend/src/slc_web/src/slc_web/tests/test_ct_community_sponsor.py

@@ -2,7 +2,11 @@
 from plone.app.testing import setRoles
 from plone.app.testing import TEST_USER_ID
 from plone.dexterity.interfaces import IDexterityFTI
+
+from slc_web import ADD_SPONSOR_ROLES
+from slc_web import MANAGE_SPONSOR_ROLES
 from slc_web.testing import SLC_WEB_INTEGRATION_TESTING
+
 from zope.component import queryUtility
 
 import unittest
@@ -22,7 +26,47 @@ def setUp(self):
         self.portal = self.layer["portal"]
         setRoles(self.portal, TEST_USER_ID, ["Manager"])
 
-    def test_fti_community_sponsor(self):
+    def test_ct_community_sponsor_fti(self):
+        """Test If CommunitySponsor exits on Dexterity FTI."""
         fti = queryUtility(IDexterityFTI, name="CommunitySponsor")
         self.assertTrue(fti)
         # self.assertNotEqual(None, fti)
+
+    def test_ct_community_sponsor_globally_addable(self):
+        """Test If CommunitySponsor is globally addable."""
+
+        setRoles(self.portal, TEST_USER_ID, ["Contributor"])
+        fti = queryUtility(IDexterityFTI, name="CommunitySponsor")
+        self.assertTrue(
+            fti.global_allow,
+            "{0} is not globally addable!".format(fti.id),
+        )
+
+    def test_ct_community_sponsor_roles(self):
+        """Test correct assigning of permissions from rolemap.xml file."""
+
+        # Test permission mapping for adding an Community Sponsor
+        sponsor_roles = [
+            r["name"]
+            for r in self.portal.rolesOfPermission(
+                "Community Sponsor: Add Community Sponsor"
+            )
+            if r["selected"]
+        ]
+        self.assertEqual(sponsor_roles, ADD_SPONSOR_ROLES)
+
+        # Test permission mapping for View Detail
+        sponsor_roles = [
+            r["name"]
+            for r in self.portal.rolesOfPermission("Community Sponsor: View Detail")
+            if r["selected"]
+        ]
+        self.assertEqual(sponsor_roles, MANAGE_SPONSOR_ROLES)
+
+        # Test permission mapping for managing Manage Sponsors
+        sponsor_roles = [
+            r["name"]
+            for r in self.portal.rolesOfPermission("Community Sponsor: Manage Sponsors")
+            if r["selected"]
+        ]
+        self.assertEqual(sponsor_roles, MANAGE_SPONSOR_ROLES)