Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] migrate up should apply all pending migrations #1010

Merged
merged 1 commit into from
Oct 26, 2022
Merged

[cli] migrate up should apply all pending migrations #1010

merged 1 commit into from
Oct 26, 2022

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Sep 1, 2022 •
edited
Loading

PR Info

Fixes

  • CLI migrate up command shouldn't assume --num 1 to be the default. Instead, the default should be None, aka apply all pending migrations

@billy1624 billy1624 self-assigned this Sep 1, 2022
@billy1624 billy1624 marked this pull request as ready for review September 6, 2022 12:10
@billy1624 billy1624 requested a review from tyt2y3 September 6, 2022 12:10
tyt2y3
tyt2y3 approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the new behaviour. Feel free to merge.

@billy1624 billy1624 merged commit cb76b8f into master Oct 26, 2022
@billy1624 billy1624 deleted the cli-migrate-up branch October 26, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees

@billy1624 billy1624

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sea-orm-cli migrate up can only apply 1 migration cargo run -- up can not update the table field
2 participants
@billy1624 @tyt2y3