added reexports for sqlx errors #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me think about it, I think we used to have a policy to not 'leaking SQLx types' |
|
I think this can be offered under |
|
Yes, I agree at least a feature guard is necessary. |
|
Okay, I will claim the task |
1 task
tyt2y3
added a commit
that referenced
this pull request
Jan 31, 2023
* added reexports for sqlx errors (#1181) Co-authored-by: erhodes <erik@space-nav.com> * Re-export SQLx error types * Apply suggestions from code review --------- Co-authored-by: e-rhodes <33500135+e-rhodes@users.noreply.github.com> Co-authored-by: erhodes <erik@space-nav.com> Co-authored-by: Chris Tsang <chris.2y3@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
With the new
RuntimeErrinDbErrit's much nicer to condition on different database errors. However, since we can't directly interact with the privateSqlxErroror the database-dependentMysql/Pg/Sqliteerrors, we don't get the full benefit of this change.New Features
sqlxerror types so users can interact with them directly.Changes
useforSqlxErrorto reexport aspub use.