Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate Related for many-to-many relation with extra columns #1260

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Generate Related for many-to-many relation with extra columns #1260

merged 1 commit into from
Dec 1, 2022

Conversation

limjiayi
Copy link
Contributor

@limjiayi limjiayi commented Nov 28, 2022 •
edited
Loading

PR Info

Bug Fixes

  • Existing logic for determining a many-to-many relation requires the number of columns in the junction table to be equal to the number of primary keys. This makes codegen work incorrectly for junction tables that record additional information about the relationship, so I have removed this requirement.

billy1624
billy1624 reviewed Nov 29, 2022
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @limjiayi, thanks for contributing!! I second the relaxation.

Thoughts? @tyt2y3

@limjiayi limjiayi force-pushed the bugfix/many-to-many-related branch from 6256863 to 8af6479 Compare November 29, 2022 11:19
@billy1624 billy1624 merged commit 8e888ed into SeaQL:master Dec 1, 2022
tyt2y3 pushed a commit that referenced this pull request Dec 2, 2022
@limjiayi @tyt2y3
generate Related for many-to-many relation with extra columns (#1260)
3532607
@limjiayi limjiayi deleted the bugfix/many-to-many-related branch March 1, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billy1624 billy1624 billy1624 approved these changes

Assignees

@limjiayi limjiayi

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate Related for many-to-many tables with extra columns
2 participants
@limjiayi @billy1624