Added InsertWithFallback so that empty iterators passed to Insert will be handled with a custom function of the users' choice
#1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… will be handled with a custom function of the users' choice
tyt2y3
reviewed
Jun 2, 2023
Comment on lines
+309
to
+310
| /// On conflict | ||
| /// |
There was a problem hiding this comment.
These examples seems to have not related to the new feature?
tyt2y3
requested changes
Jun 2, 2023
tyt2y3
reviewed
Jun 2, 2023
| pub fn exec<'a, C>( | ||
| self, | ||
| db: &'a C, | ||
| ) -> FallbackResult<R, impl Future<Output = Result<InsertResult<A>, DbErr>> + '_> |
There was a problem hiding this comment.
This certainly does not look like the right API
It should return impl Future<Output = Result<FallbackResult<InsertResult<A>>, DbErr>>
|
Can we have something simpler, like: let result: MaybeInsertResult<_> = Entity::insert_many(..).on_empty_do_nothing().exec(db).await?; |
|
We'll probably let @darkmmon take over the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
New Features
InsertWithFallback, a simple wrapper aroundInsertthat checks if the iterator passed to theInsertis empty and run a function if it is true.FallbackResult, a simple enum so that the user knows if the fallback was triggered or not.