Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade SQLx to v0.7 #1742

Merged
merged 13 commits into from
Jul 21, 2023
Merged

Upgrade SQLx to v0.7 #1742

merged 13 commits into from
Jul 21, 2023

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Jul 7, 2023 •
edited
Loading

@billy1624 billy1624 self-assigned this Jul 7, 2023
@billy1624 billy1624 mentioned this pull request Jul 7, 2023
Merged
2 tasks
@cbio-erik
Copy link

@billy1624 can you prioritize getting this into a new release next week? It seems like sqlx inner processes never close out and keep piling up more tasks in current 0.6.3 version.

⏸ Idle (68)

5m41s   82µs    0ns  5m41s 1     tokio::task <cargo>/sqlx-core-0.6.3/src/pool/inner.rs:479:5       kind=task                                          │
│         164 ⏸             5m41s  122µs    0ns  5m41s 1     tokio::task <cargo>/sqlx-core-0.6.3/src/pool/inner.rs:479:5       kind=task                                          │
│         166 ⏸             5m41s   96µs    0ns  5m41s 1     tokio::task <cargo>/sqlx-core-0.6.3/src/pool/inner.rs:479:5       kind=task                                          │
│         168 ⏸             5m41s  490µs    0ns  5m41s 1     tokio::task <cargo>/sqlx-core-0.6.3/src/pool/inner.rs:479:5       kind=task                                          │
│         170 ⏸             5m41s  322µs    0ns  5m41s 1     tokio::task <cargo>/sqlx-core-0.6.3/src/pool/inner.rs:479:5       kind=task                                          │
│         172 ⏸             5m41s  464µs    0ns  5m41s 1     tokio::task <cargo>/sqlx-core-0.6.3/src/pool/inner.rs:479:5       kind=task                                          │
│         174 ⏸             5m41s  106µs    0ns  5m41s 1     tokio::task <cargo>/sqlx-core-0.6.3/src/pool/inner.rs:479:5       kind=task                                          │
│         176 ⏸             5m41s   46ms    8ms  5m41s 43    tokio::task <cargo>/sqlx-core-0.6.3/src/pool/inner.rs:479:5       kind=task
...
│      180 ⏸               17s    3ms  213µs    17s 3     tokio::task           <cargo>/sqlx-core-0.6.3/src/pool/inner.rs:479:5       kind=task                                   │
│      191 ⏸               12s    2ms  537µs    12s 2     tokio::task           <cargo>/sqlx-core-0.6.3/src/pool/inner.rs:479:5       kind=task                                   │
│      194 ⏸                7s  199µs    0ns     7s 1     tokio::task           <cargo>/sqlx-core-0.6.3/src/pool/inner.rs:479:5       kind=task                                   │
│      197 ⏸                2s  119µs    0ns     2s 1     tokio::task           <cargo>/sqlx-core-0.6.3/src/pool/inner.rs:479:5       kind=task                                   │
│      199 ⏹               2ms   72µs   35µs    2ms 2     tokio::task           <cargo>/sqlx-core-0.6.3/src/pool/connection.rs:139:24 kind=task                                   │

@billy1624 billy1624 added this to the 0.12.x milestone Jul 11, 2023
@billy1624
Copy link
Member Author

Hey @cbio-erik, so it's being fixed in SQLx 0.7? I suppose. Is there a bug fixes on SQLx CHANGELOG?

@billy1624 billy1624 mentioned this pull request Jul 12, 2023
Merged
1 task
@billy1624 billy1624 linked an issue Jul 12, 2023 that may be closed by this pull request
[SECURITY] bump to sqlx 0.7.0 #1753
Closed
@cbio-erik
Copy link

Hey @cbio-erik, so it's being fixed in SQLx 0.7? I suppose. Is there a bug fixes on SQLx CHANGELOG?

I found a bug on our end, so plz disregard my request. But yeah, there is a bug related to inner pool in sqlx change-log. launchbadge/sqlx#2376

@johnbcodes johnbcodes mentioned this pull request Jul 15, 2023
Closed
@billy1624 billy1624 marked this pull request as ready for review July 20, 2023 07:14
@billy1624 billy1624 requested a review from tyt2y3 July 20, 2023 07:14
billy1624
billy1624 commented Jul 20, 2023
View reviewed changes
src/database/transaction.rs
Comment on lines 312 to 318
#[cfg(feature = "sqlx-mysql")]
InnerConnection::MySql(conn) => {
let query = crate::driver::sqlx_mysql::sqlx_query(&stmt);
let conn: &mut sqlx::MySqlConnection = &mut *conn;
crate::metric::metric!(self.metric_callback, &stmt, {
query.execute(conn).await.map(Into::into)
})
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyt2y3 the trick lol

@tyt2y3 tyt2y3 merged commit 9b54797 into master Jul 21, 2023
@tyt2y3 tyt2y3 deleted the sqlx-v0.7 branch July 21, 2023 17:56
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

🎉 Released In 0.12.1 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

@renovate renovate bot mentioned this pull request Aug 24, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees

@billy1624 billy1624

Labels
None yet
Projects
None yet
Milestone
0.12.x
Development

Successfully merging this pull request may close these issues.

[SECURITY] bump to sqlx 0.7.0
3 participants
@billy1624 @cbio-erik @tyt2y3