Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find_linked join with table alias #182

Merged
merged 4 commits into from
Sep 28, 2021
Merged

find_linked join with table alias #182

merged 4 commits into from
Sep 28, 2021

Conversation

billy1624
Copy link
Member

Resolve #163

@billy1624 billy1624 self-assigned this Sep 21, 2021
@tyt2y3
Copy link
Member

tyt2y3 commented Sep 22, 2021

Can we have a more comprehensive test case with more levels of joins?

@billy1624 billy1624 force-pushed the find-linked-join-alias branch from 3e6f9dc to 6c0fe30 Compare September 24, 2021 02:46
@billy1624
Copy link
Member Author

billy1624 commented Sep 24, 2021

Added more test cases on 1a61f09

@billy1624 billy1624 marked this pull request as ready for review September 24, 2021 03:30
src/query/join.rs Show resolved Hide resolved
@billy1624 billy1624 force-pushed the find-linked-join-alias branch from 1a61f09 to 9c8f5aa Compare September 27, 2021 02:36
@tyt2y3
Copy link
Member

tyt2y3 commented Sep 27, 2021

Can you move the Link definitions outside of the Entity files? perhaps to a separate file called entity_links?
I feel like it is cluttering the Entity file a bit

@billy1624
Copy link
Member Author

Yes we can!

@tyt2y3 tyt2y3 merged commit 0cfa878 into master Sep 28, 2021
@tyt2y3 tyt2y3 deleted the find-linked-join-alias branch September 28, 2021 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

find_linked() generates invalid SQL for self referencing associations
2 participants