Add Tests And Fix Build Issue For "Rework active enum" PR #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyt2y3
reviewed
Oct 9, 2023
Comment on lines
-8
to
-12
| #[cfg(any( | ||
| feature = "sqlx-mysql", | ||
| feature = "sqlx-sqlite", | ||
| feature = "sqlx-postgres" | ||
| ))] |
There was a problem hiding this comment.
I think we should be able to keep these test cases for all backend?
tyt2y3
reviewed
Oct 9, 2023
| Ok(()) | ||
| } | ||
|
|
||
| pub async fn insert_json_struct_vec_derive(db: &DatabaseConnection) -> Result<(), DbErr> { |
There was a problem hiding this comment.
did I miss it somewhere, but I don't see this function being used?
|
I'll try this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
This PR adds tests and fixes a build issue on top of #1898 that occurs when using the sea-orm crate in a project with the new code.