Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actix example bug fix #2140

Merged
merged 2 commits into from
Mar 10, 2024
Merged

actix example bug fix #2140

merged 2 commits into from
Mar 10, 2024

Conversation

ikka0426
Copy link
Contributor

@ikka0426 ikka0426 commented Mar 3, 2024 •
edited
Loading

PR Info

Bug Fixes

  • Fixed a routing bug where non-numeric one-level paths were not handled correctly.
  • Fixed an issue where data was not returned when the ID represented by a number did not exist in the database.

Changes

  • Modified the routing logic in examples/actix_example/api/src/lib.rs to return a 404 Not Found page when non-numeric paths are entered.

tyt2y3
tyt2y3 approved these changes Mar 10, 2024
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@tyt2y3 tyt2y3 merged commit 763a3f9 into SeaQL:master Mar 10, 2024
32 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 4, 2024

🎉 Released In 1.0.0 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

@ikka0426 ikka0426 deleted the 1001 branch August 5, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect Route Matching Behavior in Actix Example Code
2 participants
@ikka0426 @tyt2y3