Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream Changes - 3 #2155

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Upstream Changes - 3 #2155

merged 3 commits into from
Mar 19, 2024

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Mar 14, 2024

No description provided.

@billy1624 billy1624 force-pushed the upstream-changes-3 branch from f7505a5 to 338a979 Compare March 19, 2024 08:07
@billy1624 billy1624 marked this pull request as ready for review March 19, 2024 08:16
@billy1624 billy1624 changed the title Upstream Changes - 3 (WIP) Upstream Changes - 3 Mar 19, 2024
Comment on lines 174 to 181

let has_table = crate::has_table(db, None, table).await?;

if has_table {
Ok(())
} else {
db.execute(builder.build(&stmt)).await.map(|_| ())
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert

Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK other than the unnecessary has_table

@billy1624 billy1624 merged commit a321f0a into master Mar 19, 2024
25 of 26 checks passed
@billy1624 billy1624 deleted the upstream-changes-3 branch March 19, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants