Mark primary key columns as unique in sea-orm-codegen #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billy1624
reviewed
Jun 7, 2024
There was a problem hiding this comment.
Hey @SZenglein, thanks for the PR. Sorry, I don't think this solve the root cause of the issue. I just made a PR, #2254, would you like to take a look and try it?
Install sea-orm-cli and try it on your local machine:
cargo install sea-orm-cli --force --git https://github.com/SeaQL/sea-orm --branch cli-gen-has-one-relation
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
This is a relatively simple change where sea-orm-cli did not mark primary key columns as unique, resulting in a has_many relation where a has_one would be correct. Issue #1884 offers a complete example where the problem occurs.
I only tested this for SQLite, but it should be pretty universal.
Maybe related: #1629
Fixes: #1884
New Features
None
Bug Fixes
sea-orm-cli no longer incorrectly assumes primary key columns as non-unique.
Breaking Changes
Code generation will be different in some cases (has_many replaced by has_one).