Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed manual url parsing to use Url crate #253

Merged
merged 4 commits into from
Oct 19, 2021

Conversation

AngelOnFira
Copy link
Contributor

This changes the manual parsing of database url/uri to instead use the Url crate.

@billy1624
Copy link
Member

Hey @AngelOnFira, welcome to the party!

sea-orm-cli/src/main.rs Outdated Show resolved Hide resolved
@AngelOnFira
Copy link
Contributor Author

Hey @AngelOnFira, welcome to the party!

Hey! 👋 I'm excited to get started, I'm really loving how SeaORM is working behind the scenes so far 😃

@AngelOnFira
Copy link
Contributor Author

Also, could I make tests for the CLI? It would be helpful to test that database URLs are valid. I'm not exactly sure how I'd go about it, but I'm sure there are Rust tests that could call the CLI somehow?

@tyt2y3
Copy link
Member

tyt2y3 commented Oct 18, 2021

Yes I think it's possible to test it cli level, though a lot of setup has to be done.

Unit tests would be sufficient for the scope of this PR.

So it's up to you to decide what's interesting to work on.

@AngelOnFira
Copy link
Contributor Author

Ok, I've added the tests, so I think this is good to go! Note; I also updated the Github Actions file for them to run in CI. Any comments for how anything is done would be nice, I think I'm at the point where I'm happy with how it's implemented 💯

Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyt2y3 tyt2y3 added the hacktoberfest-accepted Hacktoberfest PRs label Oct 19, 2021
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downloaded & Tested! Nice PR :P
Thanks!! @AngelOnFira

@tyt2y3 tyt2y3 merged commit d6b83d3 into SeaQL:master Oct 19, 2021
@AngelOnFira AngelOnFira deleted the improve-database-url-parsing branch October 19, 2021 11:42
@tyt2y3
Copy link
Member

tyt2y3 commented Oct 20, 2021

Congrats on landing the first hacktoberfest PR!

@AngelOnFira
Copy link
Contributor Author

Thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Hacktoberfest PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants