Insert & Update Return Model
#339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still drafting? |
|
I planned to merge those for 0.4.1
Then, moving on to merge PRs for 0.5.0 (PR mentioned in tentative merge sequence) |
tyt2y3
reviewed
Dec 18, 2021
| @@ -89,7 +89,7 @@ pub async fn insert_active_enum(db: &DatabaseConnection) -> Result<(), DbErr> { | |||
| .unwrap() | |||
| ); | |||
|
|
|||
| let res = am.delete(db).await?; | |||
| let res = model.into_active_model().delete(db).await?; | |||
There was a problem hiding this comment.
We should add a wrapper method to Model so it can be
model.delete(db)
tyt2y3
reviewed
Dec 18, 2021
|
|
||
| let result = metadata.clone().insert(db).await?; | ||
| let result = metadata.clone().into_active_model().insert(db).await?; |
tyt2y3
approved these changes
Dec 18, 2021
|
Please open a new PR to address the above suggestions. |
billy1624
added a commit
to SeaQL/seaql.github.io
that referenced
this pull request
Dec 22, 2021
billy1624
added a commit
to SeaQL/seaql.github.io
that referenced
this pull request
Dec 22, 2021
tyt2y3
pushed a commit
to SeaQL/seaql.github.io
that referenced
this pull request
Dec 31, 2021
docs: rework `ActiveValue` (SeaQL/sea-orm#340) docs: schema_name will always be applied (SeaQL/sea-orm#370) docs: `ActiveModelBehavior::after_save` takes `Model` (SeaQL/sea-orm#339) docs: `Schema::create_enum_from_active_enum` (SeaQL/sea-orm#348) docs: `ModelTrait::delete` (SeaQL/sea-orm#396) docs: codegen SQLite (SeaQL/sea-orm#386) docs: unsigned integers (SeaQL/sea-orm#397) docs: debug log (SeaQL/sea-orm#373) blog: draft "What's new in SeaORM 0.5.0" docs: revert `save` to return Self (SeaQL/sea-orm@d5c9c65) Revert "docs: unsigned integers (SeaQL/sea-orm#397)" This reverts commit ac6d49e. docs: exclude SeaQL/sea-orm#397 in 0.5.0 blog post docs: update landing page examples docs: edit docs: edit docs: fix 0.4.x docs link build: bump docusaurus version to 2.0.0-beta.14
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
Breaking Changes
insert,updateandsavereturnModelinstead ofActiveModelActiveModelBehavior::after_savetakes<Self::Entity as EntityTrait>::Modelinstead ofActiveModel