Allow for creation of indexes for PostgreSQL and SQLite #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PostgreSQL and SQLite do not allow creation of general indexes within a `CREATE TABLE` statement, so a method is required to generate `CREATE INDEX` statements for these. `create_table_from_entity` avoids creating invalid statements for non-MySQL backends, forcing uses to explicitly run `create_index_from_entity`. Ideally creating indexes would be removed from `create_table_from_entity` entirely, but this would introduce a breaking change for MySQL use.
I agree with this change. just remove create index from create_table_from_entity entirely is fine |
tyt2y3
requested changes
Mar 15, 2022
|
Thank you for the contribution all-in-all |
Use `create_index_from_entity` for all index creation for consistency across all backends. This is a backwards incompatible change, affecting those using MySQL backend when creating the schema only.
tyt2y3
approved these changes
Mar 20, 2022
billy1624
added a commit
to SeaQL/seaql.github.io
that referenced
this pull request
Mar 25, 2022
tyt2y3
changed the title
This was referenced Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostgreSQL and SQLite do not allow creation of general indexes within a
CREATE TABLEstatement, so a method is required to generateCREATE INDEXstatements for these.create_table_from_entityavoids creating invalid statements for non-MySQL backends,forcing uses to explicitly run
create_index_from_entity. Ideally creating indexes would be removed fromcreate_table_from_entityentirely, but this would introduce a breaking change for MySQL use.PR Info
#[sea_orm(indexed)]only works for MySQL #554