Add max_connections option to CLI #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, we don't have to make it an |
Hey @benluelo, please cherrypick the useful bits :P |
Change max_connections option to default to 1 CLI generate entity with default max connection of 1
benluelo
force-pushed
the
feature/cli-max-connections
branch
from
ab806cf to
491e33f
Compare
|
Should be good to go now! |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
Adds
Adds a
--max-connectionsflag tosea-orm-cli. Some databases have limits lower than the default 10 (elephantsql free tier, for example).I was unable to get pool_options to work (hence the standalone function), I enabled the
sqlx-depand it still wasn't showing up. If anyone could help me with this please let me know!