Create a num_items_and_pages on the paginator
#768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method allows us to get both number of items and pages of a paginator with only one database query.
billy1624
reviewed
May 27, 2022
src/executor/paginator.rs
Outdated
Comment on lines
87
to
88
| /// Get the total number of items and pages in a tuple as (number_of_items, number_of_pages) | ||
| pub async fn num_items_and_pages(&self) -> Result<(usize, usize), DbErr> { |
There was a problem hiding this comment.
Hey @fistons, thanks for the contributions! I'm just thinking would it be better to return a struct with named fields: number_of_items and number_of_pages?
There was a problem hiding this comment.
yeah, two usize can sometimes be confusing
|
Thank you all |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method allows us to get both number of items and pages of a
paginator with only one database query.
Adds