Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom join on conditions #793

Merged
merged 6 commits into from
Jun 28, 2022
Merged

Custom join on conditions #793

merged 6 commits into from
Jun 28, 2022

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Jun 14, 2022

PR Info

Adds

  • RelationDef and RelationBuilder with on_condition field

src/query/join.rs Outdated Show resolved Hide resolved
@billy1624
Copy link
Member Author

Hey @tyt2y3, check this 863bb9d

@liberwang1013
Copy link
Contributor

thank you for inviting me , this implement is great. I have one more question about how it handle multiple join conditions? Can you gave me more examples?

src/entity/relation.rs Outdated Show resolved Hide resolved
@billy1624
Copy link
Member Author

thank you for inviting me , this implement is great. I have one more question about how it handle multiple join conditions? Can you gave me more examples?

Hey @liberwang1013, for example, 3efe161?

@billy1624 billy1624 marked this pull request as ready for review June 21, 2022 03:13
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API Docs and doc tests

src/entity/relation.rs Outdated Show resolved Hide resolved
src/entity/relation.rs Outdated Show resolved Hide resolved
@billy1624 billy1624 requested a review from tyt2y3 June 28, 2022 10:25
@billy1624
Copy link
Member Author

Docs added

@tyt2y3
Copy link
Member

tyt2y3 commented Jun 28, 2022

Great work!

@tyt2y3 tyt2y3 merged commit 75cb269 into master Jun 28, 2022
@tyt2y3 tyt2y3 deleted the on-condition-2 branch June 28, 2022 16:27
billy1624 added a commit to SeaQL/seaql.github.io that referenced this pull request Jul 12, 2022
tyt2y3 added a commit to SeaQL/seaql.github.io that referenced this pull request Jul 17, 2022
* Custom join condition (SeaQL/sea-orm#793)

* Migration does not depend on entity crate

* Define integer enum with repr[x] syntax

* Document datatype mappings (SeaQL/sea-orm#772)

* Cursor pagination (SeaQL/sea-orm#754, SeaQL/sea-orm#822)

* (de)serialize custom JSON types (SeaQL/sea-orm#794)

* Generate new migration file (SeaQL/sea-orm#656)

* Skip generating entity file for specific tables (SeaQL/sea-orm#837)

* Generate entity with date time crate option (SeaQL/sea-orm#724)

* Drop `SelectTwoMany::one()` method (SeaQL/sea-orm#813)

* Datatype mappings of primitives (SeaQL/sea-orm#850, SeaQL/sea-schema#75)

* Join with table alias (SeaQL/sea-orm#852)

* SQLx logging level (SeaQL/sea-orm#800)

* Insert with on conflict (SeaQL/sea-orm#791)

* Migrate generate should take file name as argument instead of option (SeaQL/sea-orm#870)

* Upgrade docusaurus to 2.0.0-beta.22

* What's new in SeaORM 0.9.0

* Move migration section forward

* Rename "Generating Database Schema" section to "Generating SeaQuery Statement"

* Fix broken links

* Edit

* Edit

* Edit

* Edit

Co-authored-by: Chris Tsang <chris.2y3@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

LinkDef with custom join condition
3 participants