-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade SQLx dependency to 0.6.x #356
Comments
@billy1624 please, add |
Hey @ikrivosheev, feel free to edit my comment :) |
@billy1624 @tyt2y3 I think we need to agree! Support both |
I think we should only support latest |
@tyt2y3 sounds good |
Okay. So after some thought, I think our dependency policy would be follows: we only support the latest release of an upstream dependency, and in SeaORM we simply follow whatever version SQLx uses. So in some cases, we need to maintain a branch of sea-query to support sea-orm while sea-query keep upgrading dependencies even before SQLx upgrades them |
I realize that it's a much less maintenance burden to backport features to an older branch than to trying to make it all work together in one codebase, given that in practice, no meaningful code change is required to switch dependency version (for the most part they compile!). |
So at any time we only maintain two sea-query branches, the latest |
@tyt2y3 I add PR |
@tyt2y3 I think we can close this issue, because sqlx is upgraded. |
So cool, I am waiting the moment the CI passes |
Cool! CI pass: https://github.com/SeaQL/sea-query/actions/runs/2596551981 |
Motivation
Upgrading SQLx dependency as well as the downstream dependencies such as
time
,uuid
,bigdecimal
, etc.Tasks
Additional Information
Potential Breaking Changes
SQLite
chrono::DateTime<FixedOffset>
timezone fixDateTime<FixedOffset>
will be stored in SQLite with the correct timezone instead of always in UTC.This was flagged as a "potentially breaking change" since it changes how dates are sent to SQLite.
Pool fixes and breaking changes
PoolOptions::connect_timeout
toacquire_timeout
for clarity.The text was updated successfully, but these errors were encountered: