-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade time dependency version to 0.3 #341
Conversation
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krivosheev I'm trying to do as you suggest but run into a problem. |
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdrouet awesome! Small comment.
src/lib.rs
Outdated
@@ -741,6 +741,7 @@ | |||
)] | |||
|
|||
pub mod backend; | |||
pub mod deps; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think deps
should be pub(crate)
, because this is internal mod.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, we need to expose it to use it in tests/*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, maybe we need to separating the tests for different time
versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or re-import this mod
in tests_cfg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My point was: when we were making some internal mod public it became part of the public API sea-query and every change is breaking...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, I'll try to fix that. For now I'm trying to find a nice way to fix the CI 😉
@jdrouet some problems with tests, because tests run with: |
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
…ther Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
The time crate version 0.3.x as been released for a while now and sea-orm is still on version 0.2, blocking the integration with tools like async-graphql which relies on 0.3.x.
PR Info
Adds
with-time-0_2
to usetime@^0.2
with-time-0_3
to usetime@^0.3