Return Results from DB executor functions
#109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Previously, the code for `Executor::fetch_all` and similar functions used `.unwrap()` internally and panicked if any error happened during the call. This could result in schema detection causing panics in cases of things like spurious network issues, connection pool exhaustion, and other transitory issues with the DB. * Migrate all of the executor functions to return `Result<T, sqlx::Error>` to bubble up errors * Update all schema detection functions to bubble up errors as well and migrate code to handle addition of `Result` return types * Note that this is a breaking change to the crate's public API surface. Callers will need to be updated to handle the fact that schema detection returns `Result`s now. * Fixes SeaQL#106
Ameobea
commented
Jun 6, 2023
🎉 Released In 0.12.0 🎉Thank you everyone for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the code for
Executor::fetch_alland similar functions used.unwrap()internally and panicked if any error happened during the call. This could result in schema detection causing panics in cases of things like spurious network issues, connection pool exhaustion, and other transitory issues with the DB.PR Info
Fixes #106
Breaking Changes
This introduces a breaking change to the crate's public API surface. Callers will need to be updated to handle the fact that schema detection returns
Results now.This is definitely unavoidable, but updating shouldn't be too difficult. Callers can just
.unwrap()to retain the existing behavior of panicking in the case of any DB or connection error.Changes
Result<T, sqlx::Error>to bubble up errorsResultreturn types