Backward compatible schema discovery for MySQL 5.6 #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billy1624
changed the title
billy1624
force-pushed
the
mysql-generation-expr
branch
from
f62908f to
57d1674
Compare
billy1624
force-pushed
the
mysql-generation-expr
branch
from
7009d82 to
91a802f
Compare
|
As much as I wanted to, I think we can't put 5.6 on our CI going forward. |
|
So we can probably give up on fixing the CI, just make sure it still works on |
|
Yeah, I will revert the CI related changes now |
|
Ready |
This was referenced Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
Bug Fixes
information_schema.columns.generaion_expressioncolumn is being added on MySQL 5.7, we'd skip select this column if the target database is MySQL 5.6 or before.