Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

CORTX-33030: In Hare, Set default log level to INFO #2155

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

pavankrishnat
Copy link
Contributor

@pavankrishnat pavankrishnat commented Aug 24, 2022

Problem:
As of now, much of the default logging in HARE is at DEBUG level. Its
recommended to use INFO as default log level, to generate just good enough logs
in production releases, and enable DEBUG log level only in development
systems. This enable system to more relevant logs in less number of lines and
hence size.

Solution:
Convert the DEBUG level of such logging to INFO level.

Signed-off-by: pavankrishnat pavan.k.thunuguntla@seagate.com

@d-nayak
Copy link
Contributor

d-nayak commented Aug 25, 2022

@pavankrishnat - Please post test results from this changeset.

@pavankrishnat
Copy link
Contributor Author

@pavankrishnat - Please post test results from this changeset.

@d-nayak - Manually deployed on 3N setup and did basic Happy Path testing, Successful.
Here are the Logs with & without Changes. http://cortx-storage.colo.seagate.com/logs1/3month-retention/CORTX-33030/

Problem:
As of now, much of the default logging in HARE is at DEBUG level. Its
recommended to use INFO as default log level, to generate just good enough logs
in production releases, and enable DEBUG log level only in development
systems. This enable system to more relevant logs in less number of lines and
hence size.

Solution:
Convert the DEBUG level of such logging to INFO level.

Signed-off-by: pavankrishnat <pavan.k.thunuguntla@seagate.com>
@pavankrishnat
Copy link
Contributor Author

created new ticket to create new mechanism to separate INFO and Debug logs ( CORTX-34070 ).

@d-nayak d-nayak merged commit bd943b6 into Seagate:main Aug 26, 2022
@pavankrishnat pavankrishnat deleted the CORTX33030 branch August 26, 2022 13:00
Copy link

@cdeshmukh cdeshmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR simply changes DEBUG logs to INFO level logs, so eventually generated logs wont be limited, but generated just with INFO tag. Need of this change suddenly felt just to satisfy this story, i see this just a workaround and not real addressing the problem.

People or QA can easily question verbosity of logs generated at INFO level, so please use proper reasoning to do such changes.

@seagate-sarang-sawant
Copy link
Contributor

Not all but some message which fits more with info level severity are converted from debug level to info. Info level messages are still within the limits. Sanitizing logs messages will be taken in subsequent logging improvement stories.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants