This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
CORTX-33151 Codacy fixes related to style and security #2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seagate-sarang-sawant
requested review from
mssawant,
Shreya-18,
supriyachavan4398 and
d-nayak
seagate-sarang-sawant
requested review from
pavankrishnat
and removed request for
supriyachavan4398
|
@seagate-sarang-sawant - Please handle DCO check - it's failing. |
d-nayak
approved these changes
Aug 26, 2022
pavankrishnat
approved these changes
Aug 26, 2022
yes, try edit commit message with signature |
seagate-sarang-sawant
force-pushed
the
codacy_fixes
branch
3 times, most recently
from
5cbbbfc
to
8a897e2
Compare
mssawant
approved these changes
Aug 30, 2022
Solution: a) Fix all pep257 issues. b) False positive and conflicting Codacy rules are disabled in codacy flake8. c) Fix medium priority and security issues. d) Fix 13 test cases in classes TestDeliveryHeraldAny & TestDeliveryHeraldAll. Signed-off-by: Sarang Sawant <sarang.sawant@seagate.com>
seagate-sarang-sawant
force-pushed
the
codacy_fixes
branch
from
8a897e2
to
08282c2
Compare
Shreya-18
approved these changes
Aug 30, 2022
|
retest this please |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: disable false positive, conflicting rules and reduce the Codacy issues.
Solution:
a) Fix all pep257 issues.
b) False positive and conflicting Codacy rules are disabled in codacy flake8.
c) Fix medium priority and security issues.