Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

CORTX-33159: Codacy Fix #882

Merged
merged 4 commits into from
Aug 9, 2022
Merged

CORTX-33159: Codacy Fix #882

merged 4 commits into from
Aug 9, 2022

Conversation

rohitkolapkar
Copy link
Contributor

@rohitkolapkar rohitkolapkar commented Aug 4, 2022

Signed-off-by: Rohit Kolapkar rohit.j.kolapkar@seagate.com

Pull Request

Problem Statement

Coding

Checklist for Author

  • Coding conventions are followed and code is consistent

Testing

Checklist for Author

  • Unit and System Tests are added
  • Test Cases cover Happy Path, Non-Happy Path and Scalability
  • Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

  • Interface change (if any) are documented
  • Side effects on other features (deployment/upgrade)
  • Dependencies on other component(s)

Review Checklist

Checklist for Author

  • JIRA number/GitHub Issue added to PR
  • PR is self reviewed
  • Jira and state/status is updated and JIRA is updated with PR link
  • Check if the description is clear and explained

Documentation

Checklist for Author

  • Changes done to WIKI / Confluence page / Quick Start Guide

Dev testing

  1. User management : passed

image

Signed-off-by: Rohit Kolapkar <rohit.j.kolapkar@seagate.com>
@cla-bot cla-bot bot added the cla-signed label Aug 4, 2022
Signed-off-by: Rohit Kolapkar <rohit.j.kolapkar@seagate.com>
Signed-off-by: Rohit Kolapkar <rohit.j.kolapkar@seagate.com>
@rohitkolapkar rohitkolapkar marked this pull request as ready for review August 8, 2022 09:20
@hessio hessio added the Status: Waiting to be Reviewed PR is waiting for reviewers to review the PR label Aug 8, 2022
@pawankumarsrivastava pawankumarsrivastava merged commit dc44064 into main Aug 9, 2022
@pawankumarsrivastava pawankumarsrivastava deleted the codacy-fix branch August 9, 2022 08:42
@rohitkolapkar rohitkolapkar removed the Status: Waiting to be Reviewed PR is waiting for reviewers to review the PR label Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants