Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

CORTX-32290: Added normalize path middleware #900

Merged
merged 8 commits into from
Sep 5, 2022

Conversation

rohitkolapkar
Copy link
Contributor

@rohitkolapkar rohitkolapkar commented Aug 30, 2022

Signed-off-by: Rohit Kolapkar rohit.j.kolapkar@seagate.com

Pull Request

Problem Statement

Design

  • Aiohttp provides a way to handle extra / in the url by adding middleware to the web app.
  • Added normalize path middleware which will discard extra / at the end of url and the matching handler will be called.

Coding

Checklist for Author

  • Coding conventions are followed and code is consistent

Testing

Checklist for Author

  • Unit and System Tests are added
  • Test Cases cover Happy Path, Non-Happy Path and Scalability
  • Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

  • Interface change (if any) are documented
  • Side effects on other features (deployment/upgrade)
  • Dependencies on other component(s)

Review Checklist

Checklist for Author

  • JIRA number/GitHub Issue added to PR
  • PR is self reviewed
  • Jira and state/status is updated and JIRA is updated with PR link
  • Check if the description is clear and explained

Documentation

Checklist for Author

  • Changes done to WIKI / Confluence page / Quick Start Guide

Dev Testing

  1. Login

image

  1. Permissions

image

  1. Logout

image

  1. capacity/status

image

  1. capacity/status/bytecount

image

  1. CSM user creation

image

  1. Create IAM user

image

  1. Add keys to IAM user

image

  1. Delete keys of an IAM User

image

Signed-off-by: Rohit Kolapkar <rohit.j.kolapkar@seagate.com>
@rohitkolapkar rohitkolapkar marked this pull request as draft August 30, 2022 08:43
Rohit Kolapkar added 3 commits August 30, 2022 14:22
Signed-off-by: Rohit Kolapkar <rohit.j.kolapkar@seagate.com>
…CORTX-32290-path

Conflicts:
	csm/core/controllers/login.py
	csm/core/controllers/storage_capacity.py
	csm/core/controllers/users.py
Signed-off-by: Rohit Kolapkar <rohit.j.kolapkar@seagate.com>
@rohitkolapkar rohitkolapkar marked this pull request as ready for review September 1, 2022 12:04
@pawankumarsrivastava pawankumarsrivastava merged commit 733e210 into Seagate:main Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants