Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

CORTX-34105: [Fixed] Invalid status code incase of rejected requests by csm-agent #904

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

rohitkolapkar
Copy link
Contributor

@rohitkolapkar rohitkolapkar commented Sep 1, 2022

Signed-off-by: Rohit Kolapkar rohit.j.kolapkar@seagate.com

Pull Request

Problem Statement

  • CORTX-34105
  • Due to throttler middleware logs modified in CORTX-30048: CSM Logs #895, agent is throwing 500 instead of 429 incase of no. of request exceeding CSM request-quota.

Coding

Checklist for Author

  • Coding conventions are followed and code is consistent

Testing

Checklist for Author

  • Unit and System Tests are added
  • Test Cases cover Happy Path, Non-Happy Path and Scalability
  • Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

  • Interface change (if any) are documented
  • Side effects on other features (deployment/upgrade)
  • Dependencies on other component(s)

Review Checklist

Checklist for Author

  • JIRA number/GitHub Issue added to PR
  • PR is self reviewed
  • Jira and state/status is updated and JIRA is updated with PR link
  • Check if the description is clear and explained

Documentation

Checklist for Author

  • Changes done to WIKI / Confluence page / Quick Start Guide

image

Signed-off-by: Rohit Kolapkar <rohit.j.kolapkar@seagate.com>
@rohitkolapkar rohitkolapkar changed the title Fixed request id bug [Fixed] Invalid status code incase of rejected requests by csm-agent Sep 1, 2022
@rohitkolapkar rohitkolapkar changed the title [Fixed] Invalid status code incase of rejected requests by csm-agent CORTX-34105: [Fixed] Invalid status code incase of rejected requests by csm-agent Sep 2, 2022
@kupranay kupranay merged commit 23bc824 into Seagate:main Sep 2, 2022
@rohitkolapkar rohitkolapkar deleted the request-id-bug branch September 2, 2022 09:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants