Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Commit

Permalink
CORTX-26280 cas: removal of redundant log (#2112)
Browse files Browse the repository at this point in the history
Problem:
While doing IO's, the mini provisioner log is getting flooded with error messages.

2022-09-02 15:52:54,235 - motr[00041]:  e8a0  ERROR  [cas/service.c:1350:cas_fom_tick]  <! rc=-2
2022-09-02 15:52:59,422 - motr[00041]:  c8a0  ERROR  [cas/service.c:1350:cas_fom_tick]  <! rc=-2
2022-09-02 15:53:04,377 - motr[00041]:  98a0  ERROR  [cas/service.c:1350:cas_fom_tick]  <! rc=-2
2022-09-02 15:53:05,571 - motr[00041]:  b8a0  ERROR  [cas/service.c:1350:cas_fom_tick]  <! rc=-2
2022-09-02 15:53:10,452 - motr[00041]:  d8a0  ERROR  [cas/service.c:1350:cas_fom_tick]  <! rc=-2
2022-09-02 15:53:16,172 - motr[00041]:  b8a0  ERROR  [cas/service.c:1350:cas_fom_tick]  <! rc=-2
2022-09-02 15:53:17,076 - motr[00041]:  98a0  ERROR  [cas/service.c:1350:cas_fom_tick]  <! rc=-2

This message can be ignored as S3 just checks if meta-data is present or not.

Solution:
Instead of M0_ERR, used M0_RC to reduce the flooding of log message.

Signed-off-by: Swapnil Chaudhary <swapnil.chaudhary@seagate.com>
  • Loading branch information
swapnil-seagate authored Sep 2, 2022
1 parent f877d85 commit bfe5dfa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cas/service.c
Original file line number Diff line number Diff line change
Expand Up @@ -1449,7 +1449,7 @@ static int cas_fom_tick(struct m0_fom *fom0)
fom->cf_ikv_nr);
m0_fom_phase_set(fom0, M0_FOPH_INIT);
} else
m0_fom_phase_move(fom0, M0_ERR(rc), M0_FOPH_FAILURE);
m0_fom_phase_move(fom0, M0_RC(rc), M0_FOPH_FAILURE);
break;
case CAS_START:
if (is_meta) {
Expand Down

0 comments on commit bfe5dfa

Please sign in to comment.