Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

m0_confc_init_wait(): initialise bob earlier #1759

Merged
merged 4 commits into from
Sep 2, 2022

Conversation

nikitadanilov
Copy link
Contributor

confc->cc_magic must be initialised earlier, otherwise m0_confc_invariant()
fails:

spiel-conf-ut
big-db motr[22808]: 4a30 FATAL [lib/assert.c:50:m0_panic] panic: (m0_confc_invariant(confc)) at m0_confc_ctx_init() (conf/confc.c:648) [git: 2.0.0-713-42-g7bcc873c-dirty] /var/motr/m0ut/m0trace.22808

Thread 11 (Thread 0x7fffe4875700 (LWP 22856)):
raise () from /lib64/libc.so.6
abort () from /lib64/libc.so.6
m0_arch_panic (c=0x7fffec2a39a0 <__pctx.21695>, ap=0x7fffe4874ac8) at lib/user_space/uassert.c:131
m0_panic (ctx=0x7fffec2a39a0 <__pctx.21695>) at lib/assert.c:52
m0_confc_ctx_init (ctx=0x7fff9002e8a8, confc=0x7ffff7d88268 <ut_reqh+44744>) at conf/confc.c:648
rm_ha_conf_open (grp=0x75cc20, ast=0x7fff9002ec10) at rm/rm_ha.c:256
m0_sm_asts_run (grp=0x75cc20) at sm/sm.c:175
loc_handler_thread (th=0x714380) at fop/fom.c:941
m0_thread_trampoline (arg=0x714388) at lib/thread.c:117

Signed-off-by: Nikita Danilov nikita.danilov@seagate.com

confc->cc_magic must be initialised earlier, otherwise m0_confc_invariant()
fails:

spiel-conf-ut
  big-db  motr[22808]:  4a30  FATAL  [lib/assert.c:50:m0_panic]  panic: (m0_confc_invariant(confc)) at m0_confc_ctx_init() (conf/confc.c:648)  [git: 2.0.0-713-42-g7bcc873c-dirty] /var/motr/m0ut/m0trace.22808

Thread 11 (Thread 0x7fffe4875700 (LWP 22856)):
    raise () from /lib64/libc.so.6
    abort () from /lib64/libc.so.6
    m0_arch_panic (c=0x7fffec2a39a0 <__pctx.21695>, ap=0x7fffe4874ac8) at lib/user_space/uassert.c:131
    m0_panic (ctx=0x7fffec2a39a0 <__pctx.21695>) at lib/assert.c:52
    m0_confc_ctx_init (ctx=0x7fff9002e8a8, confc=0x7ffff7d88268 <ut_reqh+44744>) at conf/confc.c:648
    rm_ha_conf_open (grp=0x75cc20, ast=0x7fff9002ec10) at rm/rm_ha.c:256
    m0_sm_asts_run (grp=0x75cc20) at sm/sm.c:175
    loc_handler_thread (th=0x714380) at fop/fom.c:941
    m0_thread_trampoline (arg=0x714388) at lib/thread.c:117

Signed-off-by: Nikita Danilov <nikita.danilov@seagate.com>
@cortx-admin
Copy link

Jenkins CI Result : Motr#1220

Motr Test Summary

Test ResultCountInfo
❌Failed18
📁

01motr-single-node/01net
01motr-single-node/03console
01motr-single-node/02rpcping
02motr-single-node/53clusterusage-alert
03motr-single-node/61sns-repair-motr-1n-1f
03motr-single-node/69sns-repair-motr-quiesce
03motr-single-node/62sns-repair-motr-mf
03motr-single-node/70sns-failure-after-repair-quiesce
03motr-single-node/63sns-repair-motr-1k-1f
03motr-single-node/60sns-repair-motr-1f
03motr-single-node/66sns-repair-motr-abort-quiesce
03motr-single-node/68sns-repair-motr-shutdown
03motr-single-node/64sns-repair-motr-ios-fail
03motr-single-node/71spiel-sns-motr-repair
03motr-single-node/04sss
03motr-single-node/65sns-repair-motr-abort
01motr-single-node/52motr-singlenode-sanity
01motr-single-node/00userspace-tests

🏁Skipped15
📁

01motr-single-node/28sys-kvs
01motr-single-node/35m0singlenode
01motr-single-node/04initscripts
01motr-single-node/37protocol
02motr-single-node/51kem
02motr-single-node/20rpc-session-cancel
02motr-single-node/10pver-assign
02motr-single-node/21fsync-single-node
02motr-single-node/13dgmode-io
02motr-single-node/14poolmach
02motr-single-node/11m0t1fs
02motr-single-node/26motr-user-kernel-tests
02motr-single-node/08spiel
03motr-single-node/06conf
03motr-single-node/36spare-reservation

✔️Passed10
📁

01motr-single-node/43m0crate
01motr-single-node/05confgen
01motr-single-node/06hagen
01motr-single-node/01kernel-tests
02motr-single-node/07m0d-fatal
02motr-single-node/67fdmi-plugin-multi-filters
02motr-single-node/41motr-conf-update
03motr-single-node/08spiel-multi-confd
03motr-single-node/24motr-dix-repair-lookup-insert-spiel
03motr-single-node/24motr-dix-repair-lookup-insert-m0repair

Total43🔗

CppCheck Summary

   Cppcheck: No new warnings found 👍

@cortx-admin
Copy link

Jenkins CI Result : Motr#1235

Motr Test Summary

Test ResultCountInfo
❌Failed18
📁

01motr-single-node/52motr-singlenode-sanity
01motr-single-node/01net
01motr-single-node/03console
01motr-single-node/02rpcping
02motr-single-node/53clusterusage-alert
03motr-single-node/61sns-repair-motr-1n-1f
03motr-single-node/72spiel-sns-motr-repair-quiesce
03motr-single-node/69sns-repair-motr-quiesce
03motr-single-node/62sns-repair-motr-mf
03motr-single-node/70sns-failure-after-repair-quiesce
03motr-single-node/63sns-repair-motr-1k-1f
03motr-single-node/60sns-repair-motr-1f
03motr-single-node/66sns-repair-motr-abort-quiesce
03motr-single-node/64sns-repair-motr-ios-fail
03motr-single-node/71spiel-sns-motr-repair
03motr-single-node/04sss
03motr-single-node/65sns-repair-motr-abort
01motr-single-node/00userspace-tests

🏁Skipped15
📁

01motr-single-node/28sys-kvs
01motr-single-node/35m0singlenode
01motr-single-node/04initscripts
01motr-single-node/37protocol
02motr-single-node/51kem
02motr-single-node/20rpc-session-cancel
02motr-single-node/10pver-assign
02motr-single-node/21fsync-single-node
02motr-single-node/13dgmode-io
02motr-single-node/14poolmach
02motr-single-node/11m0t1fs
02motr-single-node/26motr-user-kernel-tests
02motr-single-node/08spiel
03motr-single-node/06conf
03motr-single-node/36spare-reservation

✔️Passed11
📁

01motr-single-node/43m0crate
01motr-single-node/05confgen
01motr-single-node/06hagen
01motr-single-node/01kernel-tests
02motr-single-node/07m0d-fatal
02motr-single-node/67fdmi-plugin-multi-filters
02motr-single-node/41motr-conf-update
03motr-single-node/08spiel-multi-confd
03motr-single-node/24motr-dix-repair-lookup-insert-spiel
03motr-single-node/68sns-repair-motr-shutdown
03motr-single-node/24motr-dix-repair-lookup-insert-m0repair

Total44🔗

CppCheck Summary

   Cppcheck: No new warnings found 👍

@stale
Copy link

stale bot commented May 31, 2022

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nkommuri @mehjoshi @huanghua78 for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

@r-wambui r-wambui added rose Status: Waiting to be Reviewed PR is waiting for reviewers to review the PR labels Jun 7, 2022
@stale
Copy link

stale bot commented Jun 12, 2022

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nkommuri @mehjoshi @huanghua78 for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

@cortx-admin
Copy link

Jenkins CI Result : Motr#1433

Motr Test Summary

Test ResultCountInfo
❌Failed1
📁

01motr-single-node/00userspace-tests

🏁Skipped32
📁

01motr-single-node/28sys-kvs
01motr-single-node/35m0singlenode
01motr-single-node/04initscripts
01motr-single-node/37protocol
02motr-single-node/51kem
02motr-single-node/20rpc-session-cancel
02motr-single-node/10pver-assign
02motr-single-node/21fsync-single-node
02motr-single-node/13dgmode-io
02motr-single-node/14poolmach
02motr-single-node/11m0t1fs
02motr-single-node/26motr-user-kernel-tests
02motr-single-node/08spiel
03motr-single-node/06conf
03motr-single-node/36spare-reservation
04motr-single-node/34sns-repair-1n-1f
04motr-single-node/08spiel-sns-repair-quiesce
04motr-single-node/28sys-kvs-kernel
04motr-single-node/11m0t1fs-rconfc-fail
04motr-single-node/08spiel-sns-repair
04motr-single-node/19sns-repair-abort
04motr-single-node/22sns-repair-ios-fail
05motr-single-node/18sns-repair-quiesce
05motr-single-node/12fwait
05motr-single-node/16sns-repair-multi
05motr-single-node/07mount-fail
05motr-single-node/15sns-repair-single
05motr-single-node/23sns-abort-quiesce
05motr-single-node/17sns-repair-concurrent-io
05motr-single-node/07mount
05motr-single-node/07mount-multiple
05motr-single-node/12fsync

✔️Passed42
📁

01motr-single-node/43m0crate
01motr-single-node/05confgen
01motr-single-node/06hagen
01motr-single-node/52motr-singlenode-sanity
01motr-single-node/01net
01motr-single-node/01kernel-tests
01motr-single-node/03console
01motr-single-node/02rpcping
02motr-single-node/07m0d-fatal
02motr-single-node/67fdmi-plugin-multi-filters
02motr-single-node/53clusterusage-alert
02motr-single-node/41motr-conf-update
03motr-single-node/61sns-repair-motr-1n-1f
03motr-single-node/72spiel-sns-motr-repair-quiesce
03motr-single-node/08spiel-multi-confd
03motr-single-node/69sns-repair-motr-quiesce
03motr-single-node/62sns-repair-motr-mf
03motr-single-node/70sns-failure-after-repair-quiesce
03motr-single-node/63sns-repair-motr-1k-1f
03motr-single-node/60sns-repair-motr-1f
03motr-single-node/66sns-repair-motr-abort-quiesce
03motr-single-node/24motr-dix-repair-lookup-insert-spiel
03motr-single-node/68sns-repair-motr-shutdown
03motr-single-node/64sns-repair-motr-ios-fail
03motr-single-node/71spiel-sns-motr-repair
03motr-single-node/24motr-dix-repair-lookup-insert-m0repair
03motr-single-node/04sss
03motr-single-node/65sns-repair-motr-abort
04motr-single-node/48motr-raid0-io
04motr-single-node/49motr-rpc-cancel
04motr-single-node/25m0kv
04motr-single-node/44motr-rm-lock-cc-io
04motr-single-node/45motr-rmw
05motr-single-node/23dix-repair-m0repair
05motr-single-node/43motr-sync-replication
05motr-single-node/42motr-utils
05motr-single-node/45motr-sns-repair-N-1
05motr-single-node/40motr-dgmode
05motr-single-node/23dix-repair-quiesce-m0repair
05motr-single-node/23spiel-dix-repair-quiesce
05motr-single-node/44motr-sns-repair
05motr-single-node/23spiel-dix-repair

Total75🔗

CppCheck Summary

   Cppcheck: No new warnings found 👍

@cortx-admin
Copy link

Can one of the admins verify this patch?

@stale
Copy link

stale bot commented Aug 10, 2022

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nkommuri @mehjoshi @huanghua78 for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

1 similar comment
@stale
Copy link

stale bot commented Aug 16, 2022

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nkommuri @mehjoshi @huanghua78 for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

@madhavemuri madhavemuri merged commit e990e6f into main Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working cla-signed needs-attention rose Status: Waiting to be Reviewed PR is waiting for reviewers to review the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants