This repository has been archived by the owner on May 3, 2024. It is now read-only.
Handling 'short' write in some cases, e.g. disk full. #1888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huanghua78
requested review from
mehjoshi,
madhavemuri,
nikitadanilov,
yeshpal-jain-seagate,
andriytk,
siningwuseagate,
vidyadhar-pinglikar,
shashank-parulekar,
nkommuri,
sg-shankar,
ivan-alekhin,
sergey-shilov and
rkothiya
as code owners
|
This issue/pull request has been marked as |
|
The Jenkins test result: It is NOT automatically posted here. |
Jenkins CI Result : Motr#1522Motr Test Summary
CppCheck SummaryCppcheck: No new warnings found 👍 |
|
Can one of the admins verify this patch? |
madhavemuri
approved these changes
Aug 2, 2022
hessio
added
the
Status: Waiting to be Reviewed
|
retest this please |
In cases, e.g. disk full, the write request may return with 'short write': the written count is less than requested count. The assertion of requested write count equal to returned count is removed. In this case, the rc value of this request is still 0. And next write request may return -ENOSPC because of disk full. This can be triggered with small disks and writing a lot of data into the system. Signed-off-by: Hua Huang <hua.huang@seagate.com>
Jenkins CI Result : Motr#1586Motr Test Summary
CppCheck SummaryCppcheck: No new warnings found 👍 |
|
@huanghua78 , In case of short writes, how will the user know how much data was written? By returning the actually written bytes of data. |
|
I ran the 45motr-rmw manually, and it passed: Please note the panic happens while doing finalization, which does not impact this patch, and will be fixed soon in another PR. |
|
Another round of successful 45motr-rmw: |
Jenkins CI Result : Motr#1593Motr Test Summary
CppCheck SummaryCppcheck: No new warnings found 👍 |
Jenkins CI Result : Motr#1597Motr Test Summary
CppCheck SummaryCppcheck: No new warnings found 👍 |
kiwionly2
pushed a commit
to kiwionly2/cortx-motr
that referenced
this pull request
Aug 30, 2022
…eagate#1888) In cases, e.g. disk full, the write request may return with 'short write': the written count is less than requested count. The assertion of requested write count equal to returned count is removed. In this case, the rc value of this request is still 0. And next write request may return -ENOSPC because of disk full. This can be triggered with small disks and writing a lot of data into the system. Signed-off-by: Hua Huang <hua.huang@seagate.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Sometimes, the write request may return short write result, especially
in case of disk full. Please see: #1868
Design
We don't require the I/O request to write/read all data in the request.
Coding
Checklist for Author
Testing
Checklist for Author
Impact Analysis
Checklist for Author/Reviewer/GateKeeper
Review Checklist
Checklist for Author
Documentation
Checklist for Author