You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 3, 2024. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nkommuri@mehjoshi@huanghua78 for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.
This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nkommuri@mehjoshi@huanghua78 for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.
This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nkommuri@mehjoshi@huanghua78 for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.
This test fixes some Codacy warnings in 08spiel-multiple-confd.
This test now is skipped in a libfab environment.
But we need to test it against LNET transport if libfab is not supported in this test.
This patch fixes some of the codacy warnings.
warning fixed : "Double quote to prevent globing and words splitting".
Signed-off-by: alfhad <fahadshah2411@gmail.com>
This patch fixes some of the codacy warnings.
warning fixed : "Double quote to prevent globing and words splitting".
Signed-off-by: alfhad <fahadshah2411@gmail.com>
Signed-off-by: Rinku Kothiya <rinku.kothiya@seagate.com>
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alfhad
requested review from
mehjoshi,
madhavemuri,
nikitadanilov,
yeshpal-jain-seagate,
huanghua78,
andriytk,
siningwuseagate,
vidyadhar-pinglikar,
shashank-parulekar,
nkommuri,
sg-shankar,
ivan-alekhin,
sergey-shilov and
rkothiya
as code owners
hessio
added
the
Status: Changes requested
This patch fixes some of the codacy warnings.
warning fixed : "Double quote to prevent globing and words splitting".
Signed-off-by: alfhad fahadshah2411@gmail.com
Problem Statement
We see 1688 occurrence of pattern, "Double quote to prevent globing and words splitting".
Design
We are putting the variable references in double quotes.
Coding
Checklist for Author
Testing
Checklist for Author
Impact Analysis
Checklist for Author/Reviewer/GateKeeper
Review Checklist
Checklist for Author
Documentation
Checklist for Author