This repository has been archived by the owner on May 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 142
CORTX-30751: Codacy code cleanup (#1606) #1965
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes some of the codacy warnings. warning fixed : "Double quote to prevent globing and words splitting". Signed-off-by: Rinku Kothiya <rinku.kothiya@seagate.com>
rkothiya
requested review from
mehjoshi,
madhavemuri,
nikitadanilov,
yeshpal-jain-seagate,
huanghua78,
andriytk,
siningwuseagate,
vidyadhar-pinglikar,
shashank-parulekar,
nkommuri,
sg-shankar,
ivan-alekhin and
sergey-shilov
as code owners
July 7, 2022 09:07
This issue/pull request has been marked as |
atulsdeshmukh2312
approved these changes
Jul 19, 2022
Can one of the admins verify this patch? |
hessio
added
codacy
Status: Waiting to be Reviewed
PR is waiting for reviewers to review the PR
labels
Aug 9, 2022
huanghua78
approved these changes
Aug 11, 2022
This issue/pull request has been marked as |
retest this please |
kiwionly2
pushed a commit
to kiwionly2/cortx-motr
that referenced
this pull request
Aug 30, 2022
This patch fixes some of the codacy warnings. warning fixed : "Double quote to prevent globing and words splitting". Signed-off-by: Rinku Kothiya <rinku.kothiya@seagate.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla-signed
codacy
needs-attention
Status: Waiting to be Reviewed
PR is waiting for reviewers to review the PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes some of the codacy warnings.
warning fixed : "Double quote to prevent globing and words splitting".
Signed-off-by: Rinku Kothiya rinku.kothiya@seagate.com
Problem Statement
We see 1688 occurrence of pattern, "Double quote to prevent globing and words splitting".
Design
We are putting the variable references in double quotes.
Coding
Checklist for Author
Testing
Checklist for Author
Impact Analysis
Checklist for Author/Reviewer/GateKeeper
Review Checklist
Checklist for Author
Documentation
Checklist for Author