CORTX-33577: fix panic in degraded mode read #1970
Conversation
yatin-mahajan
requested review from
mehjoshi,
madhavemuri,
nikitadanilov,
yeshpal-jain-seagate,
huanghua78,
andriytk,
siningwuseagate,
vidyadhar-pinglikar,
shashank-parulekar,
nkommuri,
sg-shankar,
ivan-alekhin,
sergey-shilov and
rkothiya
as code owners
|
tag @andriytk to review this. |
|
This issue/pull request has been marked as |
|
@andriytk Can you review this PR. |
andriytk
changed the title
|
This issue/pull request has been marked as |
|
Can one of the admins verify this patch? |
hessio
added
the
Status: Changes requested
|
Please retest this. |
|
retest this please |
|
retest this please |
… code * It might possible that in degraded mode we may land up in a situation where there are more than K failure and read_verify_is not true. In this case ideally, we should return proper error code (-EIO) instead of assert. Signed-off-by: Yatin Mahajan <yatin.mahajan@seagate.com>
Signed-off-by: Yatin Mahajan <yatin.mahajan@seagate.com>
yatin-mahajan
force-pushed
the
CORTX-33577
branch
from
5c97763
to
ad37c8a
Compare
|
retest this please |
Jenkins CI Result : Motr#1596Motr Test Summary
CppCheck SummaryCppcheck: No new warnings found 👍 |
Problem: It might be possible that in degraded mode we may land up in a situation where there are more than K failure and read_verify_is not true. In this case ideally, we should return proper error code (-EIO) instead of assert. Solution: Fixed panic in degraded read, replaced assert with error code. Signed-off-by: Yatin Mahajan <yatin.mahajan@seagate.com>
It might be possible that in degraded mode we may land up in a situation
where there are more than K failures and read_verify_is not true. In this
case, ideally, we should return proper error code (-EIO) instead of assert.
Problem
It might be possible that in degraded mode we may land up in a situation
where there are more than K failures and read_verify_is not true.
Design
In this case, ideally, we should return proper error code (-EIO) instead of assert.
Coding
Checklist for Author
Testing
Checklist for Author
Impact Analysis
Checklist for Author/Reviewer/GateKeeper
Review Checklist
Checklist for Author
Documentation
Checklist for Author