Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

CORTX-32897: Support default parameters for pre-merge job #1987

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

rkothiya
Copy link
Contributor

@rkothiya rkothiya commented Jul 16, 2022

Since Motr-Hare-Single-Node-Cluster-Deployment-On-Rocky-Linux
will be used as a pre merge job we need to remove the parameters
that it accepts and run the job on dedicated machines.

Signed-off-by: Rinku Kothiya rinku.kothiya@seagate.com

Problem Statement

Cannot give parameters to pre merge job Motr-Hare-Single-Node-Cluster-Deployment-On-Rocky-Linux.

Design

Modified the job to run on dedicated machines.

Coding

Checklist for Author

  • Coding conventions are followed and code is consistent

Testing

Checklist for Author

  • Unit and System Tests are added
  • Test Cases cover Happy Path, Non-Happy Path and Scalability
  • Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

  • Interface change (if any) are documented
  • Side effects on other features (deployment/upgrade)
  • Dependencies on other component(s)

Review Checklist

Checklist for Author

  • JIRA number/GitHub Issue added to PR
  • PR is self reviewed
  • Jira and state/status is updated and JIRA is updated with PR link
  • Check if the description is clear and explained

Documentation

Checklist for Author

  • Changes done to WIKI / Confluence page / Quick Start Guide

@rkothiya rkothiya force-pushed the CORTX-32897 branch 3 times, most recently from 36a3611 to 2de0b27 Compare July 18, 2022 08:57
@rkothiya rkothiya marked this pull request as ready for review July 18, 2022 10:56
@rkothiya
Copy link
Contributor Author

retest this please

@rkothiya rkothiya force-pushed the CORTX-32897 branch 3 times, most recently from bff829b to 9c8d654 Compare July 21, 2022 15:14
@cortx-admin
Copy link

Can one of the admins verify this patch?

@rkothiya rkothiya force-pushed the CORTX-32897 branch 2 times, most recently from 81e41a2 to 2ca0480 Compare July 28, 2022 09:39
@rkothiya rkothiya force-pushed the CORTX-32897 branch 2 times, most recently from 542a27a to 96e8de4 Compare August 5, 2022 07:09
Copy link
Contributor

@madhavemuri madhavemuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the reference of Rock Linux from the commit message, in future we may use any OS with the same job.

Since Motr-Hare-Single-Node-Cluster-Deployment-On-Rocky-Linux
will be used as a pre merge job we need to remove the parameters
that it accepts and run the job on dedicated machines.

Signed-off-by: Rinku Kothiya <rinku.kothiya@seagate.com>
@rkothiya
Copy link
Contributor Author

rkothiya commented Aug 8, 2022

As this is a stand alone script and ci/cd job do not test this and also it does not have anything to do with deployment hence giving an exception for the pre-merge jobs.

@rkothiya rkothiya merged commit fb0d258 into Seagate:main Aug 8, 2022
@rkothiya rkothiya added the Exception Allowed to merge without runing ut and st label Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed Exception Allowed to merge without runing ut and st
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants