This repository has been archived by the owner on May 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 142
CORTX-32897: Support default parameters for pre-merge job #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkothiya
requested review from
mehjoshi,
madhavemuri,
nikitadanilov,
yeshpal-jain-seagate,
huanghua78,
andriytk,
siningwuseagate,
vidyadhar-pinglikar,
shashank-parulekar,
nkommuri,
sg-shankar,
ivan-alekhin and
sergey-shilov
as code owners
July 16, 2022 14:45
rkothiya
force-pushed
the
CORTX-32897
branch
4 times, most recently
from
July 16, 2022 17:52
e65021d
to
b95067a
Compare
rkothiya
force-pushed
the
CORTX-32897
branch
11 times, most recently
from
July 18, 2022 05:29
23770c0
to
3974f08
Compare
rkothiya
force-pushed
the
CORTX-32897
branch
3 times, most recently
from
July 18, 2022 08:57
36a3611
to
2de0b27
Compare
retest this please |
madhavemuri
reviewed
Jul 18, 2022
rkothiya
force-pushed
the
CORTX-32897
branch
3 times, most recently
from
July 21, 2022 15:14
bff829b
to
9c8d654
Compare
Can one of the admins verify this patch? |
rkothiya
force-pushed
the
CORTX-32897
branch
2 times, most recently
from
July 28, 2022 09:39
81e41a2
to
2ca0480
Compare
rkothiya
force-pushed
the
CORTX-32897
branch
2 times, most recently
from
August 5, 2022 07:09
542a27a
to
96e8de4
Compare
madhavemuri
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the reference of Rock Linux from the commit message, in future we may use any OS with the same job.
Since Motr-Hare-Single-Node-Cluster-Deployment-On-Rocky-Linux will be used as a pre merge job we need to remove the parameters that it accepts and run the job on dedicated machines. Signed-off-by: Rinku Kothiya <rinku.kothiya@seagate.com>
As this is a stand alone script and ci/cd job do not test this and also it does not have anything to do with deployment hence giving an exception for the pre-merge jobs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Motr-Hare-Single-Node-Cluster-Deployment-On-Rocky-Linux
will be used as a pre merge job we need to remove the parameters
that it accepts and run the job on dedicated machines.
Signed-off-by: Rinku Kothiya rinku.kothiya@seagate.com
Problem Statement
Cannot give parameters to pre merge job Motr-Hare-Single-Node-Cluster-Deployment-On-Rocky-Linux.
Design
Modified the job to run on dedicated machines.
Coding
Checklist for Author
Testing
Checklist for Author
Impact Analysis
Checklist for Author/Reviewer/GateKeeper
Review Checklist
Checklist for Author
Documentation
Checklist for Author