This repository has been archived by the owner on May 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 142
CORTX-33505: Add tree type in node header of btree node. #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - Inside btree `struct node_header::h_tree_type` field is not populated. Solution: - Assign tree type to `h_tree_type` variable while initializing a new node. - Added check in node invariant to ensure this field is populated. - Fixed one typo error in doc/sm/index.rst file. Signed-off-by: Kanchan Chaudhari <kanchan.chaudhari@seagate.com>
kanchan-chaudhari
requested review from
mehjoshi,
madhavemuri,
nikitadanilov,
yeshpal-jain-seagate,
huanghua78,
andriytk,
siningwuseagate,
vidyadhar-pinglikar,
shashank-parulekar,
nkommuri,
sg-shankar,
yatin-mahajan and
rkothiya
as code owners
August 5, 2022 10:14
struct fkvv_head and struct vkvv_head because this order is expected while performing data recovery. Signed-off-by: Kanchan Chaudhari <kanchan.chaudhari@seagate.com>
shashank-parulekar
approved these changes
Aug 6, 2022
upendrapatwardhan
approved these changes
Aug 8, 2022
retest this please |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kanchan Chaudhari kanchan.chaudhari@seagate.com
Problem Statement
Design
h_tree_type
variable while initializing a new node.Coding
Checklist for Author
Testing
Checklist for Author
Impact Analysis
Checklist for Author/Reviewer/GateKeeper
Review Checklist
Checklist for Author
Documentation
Checklist for Author