Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

CORTX-33927: Deployment failure due to wrong traversing of consul conf store #2073

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

atulsdeshmukh2312
Copy link
Contributor

Problem Statement

  • Deployment failure due to wrong traversing of consul conf store

Design

Change the code so that only iterations of strings are valid and not any other structures like dictionary, list etc.

Coding

Checklist for Author

  • Coding conventions are followed and code is consistent

Testing

Tested with k8s branch https://github.com/keithpine/cortx-k8s/tree/CORTX-33054_consul-confstore-url
Status after deployment:

[root@ssc-vm-g2-rhev4-3118 ~]# kubectl get pods -n default NAME READY STATUS RESTARTS AGE cortx-client-0 2/2 Running 0 61m cortx-consul-client-n5m6f 1/1 Running 0 61m cortx-consul-server-0 1/1 Running 0 61m cortx-control-dd4d9b489-tv244 1/1 Running 0 61m cortx-data-g0-0 3/3 Running 0 61m cortx-data-g1-0 3/3 Running 0 61m cortx-ha-5b84c64ff5-xqj9s 3/3 Running 0 61m cortx-kafka-0 1/1 Running 0 61m cortx-server-0 2/2 Running 0 61m cortx-zookeeper-0 1/1 Running 0 61m

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

  • Interface change (if any) are documented
  • Side effects on other features (deployment/upgrade)
  • Dependencies on other component(s)

Review Checklist

Checklist for Author

  • JIRA number/GitHub Issue added to PR
  • PR is self reviewed
  • Jira and state/status is updated and JIRA is updated with PR link
  • Check if the description is clear and explained

Documentation

Checklist for Author

  • Changes done to WIKI / Confluence page / Quick Start Guide

…f store

Signed-off-by: Atul Deshmukh <atul.deshmukh@seagate.com>
…f store

Signed-off-by: Atul Deshmukh <atul.deshmukh@seagate.com>
@atulsdeshmukh2312
Copy link
Contributor Author

Retest this please

@yeshpal-jain-seagate
Copy link
Contributor

test this please

Copy link
Contributor

@imvenkip imvenkip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rkothiya
Copy link
Contributor

Jenkins CI Result : Motr#1590

Motr Test Summary

Test ResultCountInfo
❌Failed2
📁

04motr-single-node/49motr-rpc-cancel
01motr-single-node/00userspace-tests

🏁Skipped32
📁

01motr-single-node/28sys-kvs
01motr-single-node/35m0singlenode
01motr-single-node/04initscripts
01motr-single-node/37protocol
02motr-single-node/51kem
02motr-single-node/20rpc-session-cancel
02motr-single-node/10pver-assign
02motr-single-node/21fsync-single-node
02motr-single-node/13dgmode-io
02motr-single-node/14poolmach
02motr-single-node/11m0t1fs
02motr-single-node/26motr-user-kernel-tests
02motr-single-node/08spiel
03motr-single-node/06conf
03motr-single-node/36spare-reservation
04motr-single-node/34sns-repair-1n-1f
04motr-single-node/08spiel-sns-repair-quiesce
04motr-single-node/28sys-kvs-kernel
04motr-single-node/11m0t1fs-rconfc-fail
04motr-single-node/08spiel-sns-repair
04motr-single-node/19sns-repair-abort
04motr-single-node/22sns-repair-ios-fail
05motr-single-node/18sns-repair-quiesce
05motr-single-node/12fwait
05motr-single-node/16sns-repair-multi
05motr-single-node/07mount-fail
05motr-single-node/15sns-repair-single
05motr-single-node/23sns-abort-quiesce
05motr-single-node/17sns-repair-concurrent-io
05motr-single-node/07mount
05motr-single-node/07mount-multiple
05motr-single-node/12fsync

✔️Passed41
📁

01motr-single-node/43m0crate
01motr-single-node/05confgen
01motr-single-node/06hagen
01motr-single-node/52motr-singlenode-sanity
01motr-single-node/01net
01motr-single-node/01kernel-tests
01motr-single-node/03console
01motr-single-node/02rpcping
02motr-single-node/07m0d-fatal
02motr-single-node/67fdmi-plugin-multi-filters
02motr-single-node/53clusterusage-alert
02motr-single-node/41motr-conf-update
03motr-single-node/61sns-repair-motr-1n-1f
03motr-single-node/72spiel-sns-motr-repair-quiesce
03motr-single-node/08spiel-multi-confd
03motr-single-node/69sns-repair-motr-quiesce
03motr-single-node/62sns-repair-motr-mf
03motr-single-node/70sns-failure-after-repair-quiesce
03motr-single-node/63sns-repair-motr-1k-1f
03motr-single-node/60sns-repair-motr-1f
03motr-single-node/66sns-repair-motr-abort-quiesce
03motr-single-node/24motr-dix-repair-lookup-insert-spiel
03motr-single-node/68sns-repair-motr-shutdown
03motr-single-node/64sns-repair-motr-ios-fail
03motr-single-node/71spiel-sns-motr-repair
03motr-single-node/24motr-dix-repair-lookup-insert-m0repair
03motr-single-node/04sss
03motr-single-node/65sns-repair-motr-abort
04motr-single-node/48motr-raid0-io
04motr-single-node/25m0kv
04motr-single-node/44motr-rm-lock-cc-io
04motr-single-node/45motr-rmw
05motr-single-node/23dix-repair-m0repair
05motr-single-node/43motr-sync-replication
05motr-single-node/42motr-utils
05motr-single-node/45motr-sns-repair-N-1
05motr-single-node/40motr-dgmode
05motr-single-node/23dix-repair-quiesce-m0repair
05motr-single-node/23spiel-dix-repair-quiesce
05motr-single-node/44motr-sns-repair
05motr-single-node/23spiel-dix-repair

Total75🔗

CppCheck Summary

   Cppcheck: No new warnings found 👍

@rkothiya rkothiya merged commit 965681d into Seagate:main Aug 16, 2022
kiwionly2 pushed a commit to kiwionly2/cortx-motr that referenced this pull request Aug 30, 2022
Problem: 
Deployment failure due to wrong traversing of consul conf store

Solution: 
Change the code so that only iterations of strings are valid and 
not any other structures like dictionary, list etc.

Signed-off-by: Atul Deshmukh <atul.deshmukh@seagate.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants