This repository has been archived by the owner on May 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 142
CORTX-33927: Deployment failure due to wrong traversing of consul conf store #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f store Signed-off-by: Atul Deshmukh <atul.deshmukh@seagate.com>
atulsdeshmukh2312
requested review from
mehjoshi,
madhavemuri,
nikitadanilov,
yeshpal-jain-seagate,
huanghua78,
andriytk,
siningwuseagate,
vidyadhar-pinglikar,
shashank-parulekar,
nkommuri,
sg-shankar,
yatin-mahajan and
rkothiya
as code owners
August 12, 2022 10:51
…f store Signed-off-by: Atul Deshmukh <atul.deshmukh@seagate.com>
Retest this please |
yeshpal-jain-seagate
approved these changes
Aug 12, 2022
test this please |
imvenkip
approved these changes
Aug 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
kiwionly2
pushed a commit
to kiwionly2/cortx-motr
that referenced
this pull request
Aug 30, 2022
Problem: Deployment failure due to wrong traversing of consul conf store Solution: Change the code so that only iterations of strings are valid and not any other structures like dictionary, list etc. Signed-off-by: Atul Deshmukh <atul.deshmukh@seagate.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Design
Change the code so that only iterations of strings are valid and not any other structures like dictionary, list etc.
Coding
Checklist for Author
Testing
Tested with k8s branch https://github.com/keithpine/cortx-k8s/tree/CORTX-33054_consul-confstore-url
Status after deployment:
[root@ssc-vm-g2-rhev4-3118 ~]# kubectl get pods -n default NAME READY STATUS RESTARTS AGE cortx-client-0 2/2 Running 0 61m cortx-consul-client-n5m6f 1/1 Running 0 61m cortx-consul-server-0 1/1 Running 0 61m cortx-control-dd4d9b489-tv244 1/1 Running 0 61m cortx-data-g0-0 3/3 Running 0 61m cortx-data-g1-0 3/3 Running 0 61m cortx-ha-5b84c64ff5-xqj9s 3/3 Running 0 61m cortx-kafka-0 1/1 Running 0 61m cortx-server-0 2/2 Running 0 61m cortx-zookeeper-0 1/1 Running 0 61m
Impact Analysis
Checklist for Author/Reviewer/GateKeeper
Review Checklist
Checklist for Author
Documentation
Checklist for Author