Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

go/mio: add an example of REST API server #2111

Closed
wants to merge 1 commit into from
Closed

go/mio: add an example of REST API server #2111

wants to merge 1 commit into from

Conversation

kiwionly2
Copy link
Member

@kiwionly2 kiwionly2 commented Aug 30, 2022 •
edited by markdownify bot
Loading

Signed-off-by: kiwionly2 gheewooi.ong@seagate.com

Problem Statement

  • Problem statement

Design

  • For Bug, Describe the fix here.
  • For Feature, Post the link for design

Coding

Checklist for Author

  • Coding conventions are followed and code is consistent

Testing

Checklist for Author

  • Unit and System Tests are added
  • Test Cases cover Happy Path, Non-Happy Path and Scalability
  • Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

  • Interface change (if any) are documented
  • Side effects on other features (deployment/upgrade)
  • Dependencies on other component(s)

Review Checklist

Checklist for Author

  • JIRA number/GitHub Issue added to PR
  • PR is self reviewed
  • Jira and state/status is updated and JIRA is updated with PR link
  • Check if the description is clear and explained

Documentation

Checklist for Author

  • Changes done to WIKI / Confluence page / Quick Start Guide

View rendered bindings/go/go_motr_api_server/README.md

@cla-bot
Copy link

cla-bot bot commented Aug 30, 2022

Thanks for your contribution!
The CLA bot has flagged your contribution as not having a Contributor License Agreement
in place. Note that this is not needed in the overwhelming majority of instances and this warning will usually be ignored.
The code reviewers will make a determination and may ask you to sign a CLA or may choose to ignore this warning.
More information about this can be found here.

@rkothiya
Copy link
Contributor

Can one of the admins verify this patch?

@madhavemuri
Copy link
Contributor

@andriytk : Can you please review this PR ?

andriytk
andriytk suggested changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@andriytk andriytk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description should be updated with some details at least.

Also, try to fix Codacy issues as much as possible.

andriytk
andriytk reviewed Aug 30, 2022
View reviewed changes
bindings/go/go_motr_api_server/README.md Outdated
Comment on lines 11 to 15
/api/kv/put
/api/kv/get
/api/kv/delete
/api/object/read
/api/object/write
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is /api/?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just part of the path of the url, should I remove it so the url will be much more simple ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late reply, I just back from vacation, I will remove the "/api" path accrodingly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the leading / is not needed also.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ removed.

@stale
Copy link

stale bot commented Sep 8, 2022

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nkommuri @mehjoshi @huanghua78 for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

@stale stale bot added the needs-attention label Sep 8, 2022
@cla-bot
Copy link

cla-bot bot commented Oct 3, 2022

Thanks for your contribution!
The CLA bot has flagged your contribution as not having a Contributor License Agreement
in place. Note that this is not needed in the overwhelming majority of instances and this warning will usually be ignored.
The code reviewers will make a determination and may ask you to sign a CLA or may choose to ignore this warning.
More information about this can be found here.

@stale stale bot removed the needs-attention label Oct 3, 2022
@stale
Copy link

stale bot commented Oct 12, 2022

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nkommuri @mehjoshi @huanghua78 for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

@stale
Copy link

stale bot commented Oct 16, 2022

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nkommuri @mehjoshi @huanghua78 for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

@cla-bot
Copy link

cla-bot bot commented Oct 20, 2022

Thanks for your contribution!
The CLA bot has flagged your contribution as not having a Contributor License Agreement
in place. Note that this is not needed in the overwhelming majority of instances and this warning will usually be ignored.
The code reviewers will make a determination and may ask you to sign a CLA or may choose to ignore this warning.
More information about this can be found here.

@stale stale bot removed the needs-attention label Oct 20, 2022
@cla-bot
Copy link

cla-bot bot commented Oct 20, 2022

Thanks for your contribution!
The CLA bot has flagged your contribution as not having a Contributor License Agreement
in place. Note that this is not needed in the overwhelming majority of instances and this warning will usually be ignored.
The code reviewers will make a determination and may ask you to sign a CLA or may choose to ignore this warning.
More information about this can be found here.

@kiwionly2 kiwionly2 requested review from andriytk and removed request for huanghua78, mehjoshi, rkothiya and yatin-mahajan October 20, 2022 05:30
@cla-bot
Copy link

cla-bot bot commented Oct 20, 2022

Thanks for your contribution!
The CLA bot has flagged your contribution as not having a Contributor License Agreement
in place. Note that this is not needed in the overwhelming majority of instances and this warning will usually be ignored.
The code reviewers will make a determination and may ask you to sign a CLA or may choose to ignore this warning.
More information about this can be found here.

@kiwionly2
go/mio: add an example of REST API server
e07a5a2 
Signed-off-by: kiwionly2 <gheewooi.ong@seagate.com>
@cla-bot
Copy link

cla-bot bot commented Oct 20, 2022

Thanks for your contribution!
The CLA bot has flagged your contribution as not having a Contributor License Agreement
in place. Note that this is not needed in the overwhelming majority of instances and this warning will usually be ignored.
The code reviewers will make a determination and may ask you to sign a CLA or may choose to ignore this warning.
More information about this can be found here.

@stale
Copy link

stale bot commented Oct 29, 2022

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nkommuri @mehjoshi @huanghua78 for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

@shailesh-vaidya
Copy link
Contributor

Closing as an obsolete

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@madhavemuri madhavemuri Awaiting requested review from madhavemuri

@nikitadanilov nikitadanilov Awaiting requested review from nikitadanilov

@yeshpal-jain-seagate yeshpal-jain-seagate Awaiting requested review from yeshpal-jain-seagate

@siningwuseagate siningwuseagate Awaiting requested review from siningwuseagate siningwuseagate is a code owner

@vidyadhar-pinglikar vidyadhar-pinglikar Awaiting requested review from vidyadhar-pinglikar

@shashank-parulekar shashank-parulekar Awaiting requested review from shashank-parulekar

@nkommuri nkommuri Awaiting requested review from nkommuri nkommuri is a code owner

@sg-shankar sg-shankar Awaiting requested review from sg-shankar

@andriytk andriytk Awaiting requested review from andriytk andriytk is a code owner

Assignees

@nikitadanilov nikitadanilov

@madhavemuri madhavemuri

@mehjoshi mehjoshi

Labels
needs-attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kiwionly2 @rkothiya @madhavemuri @shailesh-vaidya @andriytk @nikitadanilov @mehjoshi