Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Update Codacy Badge #6399

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Update Codacy Badge #6399

merged 3 commits into from
Aug 16, 2022

Conversation

hessio
Copy link
Contributor

@hessio hessio commented Aug 8, 2022

Resolves issue #1528

Signed-off-by: Patrick Hession patrick.hession@seagate.com

Problem Statement

  • Problem statement

Design

  • For Bug, Describe the fix here.
  • For Feature, Post the link for design

Coding

Checklist for Author

  • Coding conventions are followed and code is consistent

Testing

Checklist for Author

  • Unit and System Tests are added
  • Test Cases cover Happy Path, Non-Happy Path and Scalability
  • Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

  • Interface change (if any) are documented
  • Side effects on other features (deployment/upgrade)
  • Dependencies on other component(s)

Review Checklist

Checklist for Author

  • JIRA number/GitHub Issue added to PR
  • PR is self reviewed
  • Jira and state/status is updated and JIRA is updated with PR link
  • Check if the description is clear and explained

Documentation

Checklist for Author

  • Changes done to WIKI / Confluence page / Quick Start Guide

View rendered README.md

Resolves [issue #1528](Seagate/cortx#1528)



Signed-off-by: Patrick Hession <patrick.hession@seagate.com>
@welcome
Copy link

welcome bot commented Aug 8, 2022

Thanks for your contribution in opening this pull request! Now you can be rewarded with a CORTX sticker by requesting cortx sticker
In the meantime, please check out the contributing guidelines and explore other ways you can get involved.

@cla-bot cla-bot bot added the cla-signed label Aug 8, 2022
@hessio hessio added the Status: Waiting to Reviewed PR is waiting for reviewers to review the PR label Aug 9, 2022
@hessio
Copy link
Contributor Author

hessio commented Aug 9, 2022

@tanujashinde0405 @nitin-seagate kindly review when you have a chance

Copy link
Contributor

@nitin-seagate nitin-seagate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hessio
Copy link
Contributor Author

hessio commented Aug 16, 2022

Please merge this

@tanujashinde0405 tanujashinde0405 merged commit abcd056 into main Aug 16, 2022
@welcome
Copy link

welcome bot commented Aug 16, 2022

Thanks for your contribution to CORTX! 🎉

@tanujashinde0405 tanujashinde0405 deleted the hessio-patch-1 branch August 16, 2022 10:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed Status: Waiting to Reviewed PR is waiting for reviewers to review the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codacy Badge is not rendering properly for five docs
3 participants