Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

CORTX-32833: resolve codacy issues from provisioner repo #6403

Merged
merged 6 commits into from
Aug 22, 2022

Conversation

tanujashinde0405
Copy link
Contributor

@tanujashinde0405 tanujashinde0405 commented Aug 22, 2022

Signed-off-by: Tanuja Shinde tanuja.shinde@seagate.com

Problem Statement

  • resolve codacy issues from provisioner repo

Design

  • For Bug, Describe the fix here.
  • For Feature, Post the link for design

Coding

Checklist for Author

  • Coding conventions are followed and code is consistent

Testing

Checklist for Author

  • Unit and System Tests are added
  • Test Cases cover Happy Path, Non-Happy Path and Scalability
  • Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

  • Interface change (if any) are documented
  • Side effects on other features (deployment/upgrade)
  • Dependencies on other component(s)

Review Checklist

Checklist for Author

  • JIRA number/GitHub Issue added to PR
  • PR is self reviewed
  • Jira and state/status is updated and JIRA is updated with PR link
  • Check if the description is clear and explained

Documentation

Checklist for Author

  • Changes done to WIKI / Confluence page / Quick Start Guide

Signed-off-by: Tanuja Shinde <tanuja.shinde@seagate.com>
Signed-off-by: Tanuja Shinde <tanuja.shinde@seagate.com>
Copy link
Contributor

@nitin-seagate nitin-seagate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/setup/test_multiple_storage_sets.py Show resolved Hide resolved
Signed-off-by: Tanuja Shinde <tanuja.shinde@seagate.com>
Signed-off-by: Tanuja Shinde <tanuja.shinde@seagate.com>
Copy link

@jaikumargidwani jaikumargidwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Tanuja Shinde <tanuja.shinde@seagate.com>
Signed-off-by: Tanuja Shinde <tanuja.shinde@seagate.com>
@tanujashinde0405 tanujashinde0405 merged commit 948dee4 into main Aug 22, 2022
@tanujashinde0405 tanujashinde0405 deleted the CORTX-32833 branch August 22, 2022 10:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants