Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

CORTX-32832: fixing unit tests in test_setup #6407

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Conversation

lakshita-jain
Copy link
Contributor

@lakshita-jain lakshita-jain commented Aug 30, 2022

Signed-off-by: Lakshita Jain lakshita.jain@seagate.com

Problem Statement

  • fix the existing Unit Tests in Provisioner

Design

  • add cortx_setup module in imports
  • For Feature, Post the link for design

Coding

Checklist for Author

  • Coding conventions are followed and code is consistent

Testing

Checklist for Author

  • Unit and System Tests are added
  • Test Cases cover Happy Path, Non-Happy Path and Scalability
  • Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

  • Interface change (if any) are documented
  • Side effects on other features (deployment/upgrade)
  • Dependencies on other component(s)

Review Checklist

Checklist for Author

  • JIRA number/GitHub Issue added to PR
  • PR is self reviewed
  • Jira and state/status is updated and JIRA is updated with PR link
  • Check if the description is clear and explained

Documentation

Checklist for Author

  • Changes done to WIKI / Confluence page / Quick Start Guide

Signed-off-by: Lakshita Jain <lakshita.jain@seagate.com>
@cla-bot
Copy link

cla-bot bot commented Aug 30, 2022

Thanks for your contribution!
The CLA bot has flagged your contribution as not having a Contributor License Agreement
in place. Note that this is not needed in the overwhelming majority of instances and this warning will usually be ignored.
The code reviewers will make a determination and may ask you to sign a CLA or may choose to ignore this warning.
More information about this can be found here.

Copy link
Contributor

@tanujashinde0405 tanujashinde0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix codacy

@lakshita-jain
Copy link
Contributor Author

fix codacy
@tanujashinde0405: The codacy cant be fixed as the module is being used in line number 45( sys.modules), removing the package will throw error and the unit tests will fail.

@cla-bot cla-bot bot added the cla-signed label Sep 5, 2022
Copy link
Contributor

@nitin-seagate nitin-seagate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix codacy issue...

@tanujashinde0405 tanujashinde0405 merged commit 18a2782 into main Sep 6, 2022
@tanujashinde0405 tanujashinde0405 deleted the CORTX-32832 branch September 7, 2022 04:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants