Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

CORTX-33037: apply support bundle time filter #111

Merged
merged 3 commits into from
Jul 15, 2022
Merged

CORTX-33037: apply support bundle time filter #111

merged 3 commits into from
Jul 15, 2022

Conversation

rohit-k-dwivedi
Copy link
Contributor

@rohit-k-dwivedi rohit-k-dwivedi commented Jul 12, 2022 •
edited
Loading

Signed-off-by: rohit-k-dwivedi rohit.k.dwivedi@seagate.com

Problem Statement

  • NO time filter in rgw support bundle

Design

  • implemented time base log filter using cortx-utils limit_time method

Coding

Checklist for Author

  • Coding conventions are followed and code is consistent

Testing

Checklist for Author

  • Unit and System Tests are added
  • Test Cases cover Happy Path, Non-Happy Path and Scalability
  • Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

  • Interface change (if any) are documented
  • Side effects on other features (deployment/upgrade)
  • Dependencies on other component(s)

Review Checklist

Checklist for Author

  • JIRA number/GitHub Issue added to PR
  • PR is self reviewed
  • Jira and state/status is updated and JIRA is updated with PR link
  • Check if the description is clear and explained

Documentation

Checklist for Author

  • Changes done to WIKI / Confluence page / Quick Start Guide

@cla-bot cla-bot bot added the cla-signed label Jul 12, 2022
@rohit-k-dwivedi rohit-k-dwivedi marked this pull request as ready for review July 12, 2022 15:16
@rohit-k-dwivedi rohit-k-dwivedi changed the title CORTX-33037: apply support bundle time filter [WIP] CORTX-33037: apply support bundle time filter Jul 12, 2022
@rohit-k-dwivedi rohit-k-dwivedi marked this pull request as draft July 12, 2022 15:21
@rohit-k-dwivedi rohit-k-dwivedi marked this pull request as ready for review July 13, 2022 07:36
@rohit-k-dwivedi rohit-k-dwivedi changed the title [WIP] CORTX-33037: apply support bundle time filter CORTX-33037: apply support bundle time filter Jul 13, 2022
cdeshmukh
cdeshmukh reviewed Jul 13, 2022
View reviewed changes
src/rgw/const.py Outdated Show resolved Hide resolved
src/rgw/support/rgw_support_bundle Outdated Show resolved Hide resolved
@cdeshmukh
Copy link
Contributor

test this please

@rohit-k-dwivedi
CORTX-33037: apply support bundle time filter
37860d7 
Signed-off-by: rohit-k-dwivedi <rohit.k.dwivedi@seagate.com>
@cdeshmukh
Copy link
Contributor

retest this please

@cdeshmukh cdeshmukh merged commit e34ae2b into main Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sachitanands sachitanands sachitanands approved these changes

@cdeshmukh cdeshmukh cdeshmukh approved these changes

@rahul-tripathi-git rahul-tripathi-git Awaiting requested review from rahul-tripathi-git

@suryakumar1024 suryakumar1024 Awaiting requested review from suryakumar1024

@selvakumaar5496 selvakumaar5496 Awaiting requested review from selvakumaar5496

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohit-k-dwivedi @cdeshmukh @sachitanands