This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
CORTX-32039: Add rgw core file clean up script as part of system's logrotate directory. #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…grotate Signed-off-by: Sachitanand Shelake <sachitanand.shelake@seagate.com>
sachitanands
requested review from
priyanka25081999,
shraddhaghatol and
shriya-deshmukh
August 21, 2022 08:29
Signed-off-by: Sachitanand Shelake <sachitanand.shelake@seagate.com>
priyanka25081999
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Signed-off-by: Sachitanand Shelake <sachitanand.shelake@seagate.com>
cdeshmukh
reviewed
Aug 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also address codacy issues
Signed-off-by: Sachitanand Shelake <sachitanand.shelake@seagate.com>
cdeshmukh
reviewed
Aug 22, 2022
Signed-off-by: Sachitanand Shelake <sachitanand.shelake@seagate.com>
sachitanands
force-pushed
the
br/sachit/CORTX-32039
branch
from
August 22, 2022 13:10
7393638
to
c0e5481
Compare
cdeshmukh
reviewed
Aug 23, 2022
shriya-deshmukh
approved these changes
Aug 23, 2022
cdeshmukh
approved these changes
Aug 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sachitanand Shelake sachitanand.shelake@seagate.com
Problem Statement
Design
Coding
Checklist for Author
Testing
Checklist for Author
Impact Analysis
Checklist for Author/Reviewer/GateKeeper
Review Checklist
Checklist for Author
Documentation
Checklist for Author