This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
rgw: [CORTX-32688] Enable GC for MOTR #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ra code (#356) * rgw_sal_motr, motr_gc: [CORTX-33148] add MotrGC, MotrGC::GCWorker infra code Behaviour - With Garbage Collector enabled, MotrGC will have GC indexes & GC worker threads. - GC worker threads will run for the configured max processing time and then will wait for the configured time between two consecutive runs. Additions/Changes - Add the Garbage Collector infrastructure to support the start & stop of worker threads. - MotrGC class with the interfaces to initialize(), start(), stop() and finalize(). - GCWorker class with entry() and stop() methods. - Refactor Initialization of MotrStore - add setter methods to configure MotrStore - add initialize() method to call initialization of all the other components eg. MetadataCache, GC, (in future LC, QuotaHandler), etc. Signed-off-by: Sumedh Anantrao Kulkarni <sumedh.a.kulkarni@seagate.com>
Implement GC metadata structure & corresponding functions Added motr_gc_obj_info structure to hold gc metadata for an object marked for deletion. Added logic for creating GC indices based on config parameters. Signed-off-by: Jeet Jain <jeet.jain@seagate.com>
The GC thread will aquire GC index and process the object entries for deletion either upto the count governed by "rgw_gc_max_trim_chunk" or time allowed by "rgw_gc_processor_max_time". Signed-off-by: Sachin Punadikar <sachin.punadikar@seagate.com>
#373) * rgw_sal_motr: [CORTX-33691] Defines abstract synchronization primitives and implements it for Motr GC across multiple RGW instances. Signed-off-by: Dattaprasad Govekar <dattaprasad.govekar@seagate.com> * motr_sync_impl: [CORTX-33691] update lock() & remove_lock() methods Update and refactor the MotrLock::lock() and MotrKVLockProvider::remove_lock() methods. Signed-off-by: Sumedh Anantrao Kulkarni <sumedh.a.kulkarni@seagate.com> Co-authored-by: Dattaprasad Govekar <dattaprasad.govekar@seagate.com>
Signed-off-by: Jeet Jain <jeet.jain@seagate.com>
Signed-off-by: Jeet Jain <jeet.jain@seagate.com>
* rgw_sal_motr, motr_gc: [CORTX-32689] Implement MotrGC::enqueue()
* Push {0_ObjTag: motr_gc_obj_info} and {1_ExpiryTime: motr_gc_obj_info}
entry to the gc queues, i.e. motr dix.
* Call gc->enqueue() method on simple object delete request without
actually deleting the obj.
Signed-off-by: Sumedh Anantrao Kulkarni <sumedh.a.kulkarni@seagate.com>
* motr_gc: [CORTX-32689] Implement MotrGC::list() function
MotrGC::list() goes through every gc queue and lists the adds the
pending delete requests in resultant vector.
Interface to list objs using admin tool or rest api's is yet
to be developed.
Signed-off-by: Sumedh Anantrao Kulkarni <sumedh.a.kulkarni@seagate.com>
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
jjxsg
force-pushed
the
CORTX-32688
branch
2 times, most recently
from
fefc513
to
892f8bb
Compare
sumedhak27
reviewed
Aug 8, 2022
sumedhak27
reviewed
Aug 8, 2022
jjxsg
force-pushed
the
CORTX-32688
branch
3 times, most recently
from
d493c8d
to
b433c2f
Compare
Signed-off-by: Jeet Jain <jeet.jain@seagate.com>
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
…ke file Signed-off-by: Jeet Jain <jeet.jain@seagate.com>
jjxsg
force-pushed
the
CORTX-32688
branch
3 times, most recently
from
352f14f
to
c1e3172
Compare
sumedhak27
reviewed
Aug 9, 2022
Signed-off-by: Jeet Jain <jeet.jain@seagate.com>
sumedhak27
reviewed
Aug 12, 2022
sumedhak27
reviewed
Aug 12, 2022
sumedhak27
reviewed
Aug 12, 2022
sumedhak27
approved these changes
Aug 12, 2022
Signed-off-by: Jeet Jain <jeet.jain@seagate.com>
DPG17
reviewed
Aug 12, 2022
shriya-deshmukh
pushed a commit
to shriya-deshmukh/cortx-rgw
that referenced
this pull request
Aug 19, 2022
Implementation of MOTR GC consumer module. The following parameters are honoured with GC initialization and processing. ``` rgw_enable_gc_threads rgw_gc_max_objs rgw_gc_obj_min_wait rgw_gc_processor_max_time rgw_gc_processor_period rgw_gc_max_concurrent_io rgw_gc_max_trim_chunk ``` The following CLI command is also enabled for listing objects in GC queue (for dev testing): ``` bin/radosgw-admin gc list --no-mon-config ``` Signed-off-by: Jeet Jain <jeet.jain@seagate.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of MOTR GC consumer module. The following parameters are honored with GC initialization and processing.
GC Deletion Logs
The following cli command is also enabled for listing objects in GC queue (for dev testing):
Sample GC List Output
$ bin/radosgw-admin gc list --no-mon-config 2022-08-11T23:50:53.288-0600 7fc7d015b680 -1 WARNING: all dangerous and experimental features are enabled. 2022-08-11T23:50:53.288-0600 7fc7d015b680 -1 WARNING: all dangerous and experimental features are enabled. 2022-08-11T23:50:53.289-0600 7fc7d015b680 -1 WARNING: all dangerous and experimental features are enabled. 2022-08-11T23:50:53.289-0600 7fc7d015b680 1 RGW CONF BACKEND STORE = motr 2022-08-11T23:50:53.289-0600 7fc7d015b680 1 RGW BACKEND STORE = motr 2022-08-11T23:50:53.289-0600 7fc7d015b680 0 INFO: motr my endpoint: inet:tcp:10.230.241.24@22501 2022-08-11T23:50:53.289-0600 7fc7d015b680 0 INFO: motr ha endpoint: inet:tcp:10.230.241.24@22001 2022-08-11T23:50:53.289-0600 7fc7d015b680 0 INFO: motr my fid: 0x7200000000000001:0x3 2022-08-11T23:50:53.289-0600 7fc7d015b680 0 INFO: motr profile fid: 0x7000000000000001:0x0 2022-08-11T23:50:53.289-0600 7fc7d015b680 0 INFO: motr addb enabled: 0 2022-08-11T23:50:53.289-0600 7fc7d015b680 0 INFO: init flags: 0 2022-08-11T23:50:53.289-0600 7fc7d015b680 0 INFO: motr admin endpoint: inet:tcp:10.230.241.24@22502 2022-08-11T23:50:53.289-0600 7fc7d015b680 0 INFO: motr admin fid: 0x7200000000000001:0x4 [ { "tag": "lx25891160:lx16146530564033216512", "name": "testbkt/1M_OBJ\u0007", "deletion_time": "1660283421", "size": "1048576", "size_actual": "1048576" }, { "tag": "lx25891160:lx16146530564033216513", "name": "testbkt/1M_OBJ\u0007", "deletion_time": "1660283449", "size": "1048576", "size_actual": "1048576" } ]Signed-off-by: Jeet Jain jeet.jain@seagate.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox