Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

motr_sal: [CORTX-32689] Fix multipart download issue #399

Merged
merged 1 commit into from
Aug 20, 2022

Conversation

DPG17
Copy link

@DPG17 DPG17 commented Aug 19, 2022

Problem:
After DI changes, the unit size is limited to 1MB for objects >= 1MB.
In SNS 3+2 config, the first part object for a 10MB object is partially
uploaded, causing EIO (-5) error during Get obj API call.

Solution:
Use part object size to calculate optimal block size.

Signed-off-by: Dattaprasad Govekar dattaprasad.govekar@seagate.com

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@DPG17 DPG17 self-assigned this Aug 19, 2022
@github-actions github-actions bot added the rgw label Aug 19, 2022
Problem:
After DI changes, the unit size is limited to 1MB for objects >= 1MB.
In SNS 3+2 config, the first part object for a 10MB object is partially
uploaded, causing EIO (-5) error during Get obj API call.

Solution:
Use part object size to calculate optimal block size.

Signed-off-by: Dattaprasad Govekar <dattaprasad.govekar@seagate.com>
Copy link

@sjain09 sjain09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

Copy link

@sachinpunadikar sachinpunadikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sachinpunadikar
Copy link

retest this please

@sachinpunadikar sachinpunadikar merged commit db76065 into Seagate:main Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants