This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
rgw_sal_motr: [CORTX-34181] allow multiparts with offline server #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we create an additional index for each multipart- uploaded object to store its parts. If some server is down, the index creation operation would fail, thus failing the multipart upload. Solution: don't create indexes on multipart uploads. Create an additional index to store objs parts when the bucket is created. Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
jjxsg
reviewed
Sep 13, 2022
jjxsg
reviewed
Sep 13, 2022
Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
sumedhak27
reviewed
Sep 14, 2022
sumedhak27
reviewed
Sep 14, 2022
sumedhak27
reviewed
Sep 14, 2022
Co-authored-by: Sumedh Anantrao Kulkarni <sumedh.a.kulkarni@seagate.com> Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
jjxsg
approved these changes
Sep 14, 2022
|
Ran a smoke tests manually on my devvm setup (writing/reading/checking multipart uploaded object) with and without caching enabled - it seems working fine. |
|
Hi @andriytk Could you please run Sanity ceph test suite with your PR. this is to make sure existing tests are not breaking. |
sumedhak27
approved these changes
Sep 16, 2022
|
test_multipart_upload_multiple_sizes has failed, trying to figure out the problem... |
|
Reproduced: |
DPG17
reviewed
Sep 16, 2022
Use key prefix when calling next_query_by_name() from bucket multiparts index to avoid fetching not relevant parts. Also, use the correct key at MotrGC::process_parts() when deleting the parts from bucket multiparts index. Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
|
retest this please |
1 similar comment
|
retest this please |
siningwuseagate
approved these changes
Sep 18, 2022
|
retest this please |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we create an additional index for each multipart-uploaded object to store its parts. If some server is down, the index creation operation would fail, thus failing the multipart upload.
Solution: don't create indexes on multipart uploads. Create an additional index to store objs parts when the bucket is created.
Closes #422.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox