Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

CORTX-32168: Added Codeowner for Utils #837

Merged
merged 6 commits into from
Aug 9, 2022
Merged

Conversation

mukul-seagate11
Copy link
Contributor

Signed-off-by: Mukul Malhotra mukul.malhotra@seagate.com

Problem Statement

  • Added Codeowner for Utils

Design

  • For Bug describe the fix here.
  • For Feature, Post the link to the solution page on the confluence CORTX Foundation Library

Coding

  • Coding conventions are followed and code is consistent [Y/N]:
  • Confirm All CODACY errors are resolved [Y/N]:

Testing

  • Are test cases updated along with code changes due to Enhancements/Bugs [Y/N]:
  • Confirm that new test cases are added to regression and sanity plan files and relevant feature plan files [Y/N]:
  • Confirm that Test Cases are added for new features added [Y/N]:
  • Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]:
  • Confirm Testing was performed with installed RPM/K8s deployment [Y/N]:

Review Checklist

Before posting the PR please ensure:

  • PR is self reviewed
  • Is there a change in filename/package/module or signature [Y/N]:
  • If yes for above point, Is a notification sent to all other cortx components [Y/N]
  • New package/s added to setup.py?
  • Jira is updated
  • Check if the description is clear and explained.
  • Check Acceptance Criterion is defined.
  • All the tests performed should be mentioned before Resolving a JIRA.
  • Verification needs to be done before marked as Closed/Verified.

KVstore/Confstore feature (changes/fixes) checklist

Confirm changes are made for:

  • ConfStore
  • KVStore
  • ConfCli
  • Test cases added for all above 3
  • changes done in all the KVpayloads (ConsulKvPayload, IniKvPayload, KvPayload)

Documentation

  • Changes done to WIKI / Confluence page

Signed-off-by: Mukul Malhotra <mukul.malhotra@seagate.com>
mukul-seagate11 and others added 2 commits June 17, 2022 00:42
Signed-off-by: Mukul Malhotra <mukul.malhotra@seagate.com>
@stale
Copy link

stale bot commented Jun 27, 2022

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @s-arya @sachinpunadikar for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

@stale stale bot removed the needs-attention label Jul 25, 2022
@stale
Copy link

stale bot commented Jul 30, 2022

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @s-arya @sachinpunadikar for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

@hessio
Copy link
Contributor

hessio commented Aug 8, 2022

@mukul-seagate11 please update branch and merge

@hessio hessio added the Status: Waiting to be Merged PR is waiting to be merged label Aug 8, 2022
@mukul-seagate11
Copy link
Contributor Author

I had updated the local branch but PR need to be merge the repo gatekeepers

@sachinpunadikar sachinpunadikar merged commit 8ca8276 into main Aug 9, 2022
@sachinpunadikar sachinpunadikar deleted the mukul-codeowner branch August 9, 2022 04:59
lakshita-jain pushed a commit that referenced this pull request Aug 9, 2022
* added codeowner

Signed-off-by: Mukul Malhotra <mukul.malhotra@seagate.com>

* added codeowner

Signed-off-by: Mukul Malhotra <mukul.malhotra@seagate.com>

Co-authored-by: Rahul Tripathi <rahul.tripathi@seagate.com>
Co-authored-by: Tanuja Shinde <tanuja.shinde@seagate.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Waiting to be Merged PR is waiting to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants